Expose changes in the network quality to the renderers

net/nqe/network_quality_estimator.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
 #define NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 93 matching lines @@
     // computed estimates of the HTTP RTT, transport RTT and downstream
     // throughput (in kilobits per second), respectively. If an estimate of the
     // HTTP or transport RTT is unavailable, it will be set to
     // nqe::internal::InvalidRTT(). If the throughput estimate is unavailable,
     // it will be set to nqe::internal::kInvalidThroughput.
     virtual void OnRTTOrThroughputEstimatesComputed(
         base::TimeDelta http_rtt,
         base::TimeDelta transport_rtt,
         int32_t downstream_throughput_kbps) = 0;
 
+    virtual ~RTTAndThroughputEstimatesObserver() {}
+
    protected:
     RTTAndThroughputEstimatesObserver() {}
-    virtual ~RTTAndThroughputEstimatesObserver() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(RTTAndThroughputEstimatesObserver);
   };
 
   // Observes measurements of round trip time.
   class NET_EXPORT_PRIVATE RTTObserver {
    public:
     // Will be called when a new RTT observation is available. The round trip
     // time is specified in milliseconds. The time when the observation was
@@ skipping 312 matching lines @@
   virtual base::TimeDelta GetRTTEstimateInternal(
       const std::vector<NetworkQualityObservationSource>&
           disallowed_observation_sources,
       base::TimeTicks start_time,
       const base::Optional<Statistic>& statistic,
       int percentile) const;
   int32_t GetDownlinkThroughputKbpsEstimateInternal(
       const base::TimeTicks& start_time,
       int percentile) const;
 
+  // Observer list for RTT or throughput estimates. Protected for testing.
+  base::ObserverList<RTTAndThroughputEstimatesObserver>
+      rtt_and_throughput_estimates_observer_list_;
+
  private:
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
                            AdaptiveRecomputationEffectiveConnectionType);
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, StoreObservations);
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, TestAddObservation);
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
                            DefaultObservationsOverridden);
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
                            ObtainAlgorithmToUseFromParams);
   FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, ComputedPercentiles);
@@ skipping 277 matching lines @@
   nqe::internal::NetworkQuality external_estimate_provider_quality_;
 
   // ExternalEstimateProvider that provides network quality using operating
   // system APIs. May be NULL.
   const std::unique_ptr<ExternalEstimateProvider> external_estimate_provider_;
 
   // Observer list for changes in effective connection type.
   base::ObserverList<EffectiveConnectionTypeObserver>
       effective_connection_type_observer_list_;
 
-  // Observer list for RTT or throughput estimates.
-  base::ObserverList<RTTAndThroughputEstimatesObserver>
-      rtt_and_throughput_estimates_observer_list_;
-
   // Observer lists for round trip times and throughput measurements.
   base::ObserverList<RTTObserver> rtt_observer_list_;
   base::ObserverList<ThroughputObserver> throughput_observer_list_;
 
   std::unique_ptr<SocketPerformanceWatcherFactory> watcher_factory_;
 
   // Takes throughput measurements, and passes them back to |this| through the
   // provided callback. |this| stores the throughput observations in
   // |downstream_throughput_kbps_observations_|, which are later used for
   // estimating the throughput.
@@ skipping 49 matching lines @@
       disallowed_observation_sources_for_transport_;
 
   base::WeakPtrFactory<NetworkQualityEstimator> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkQualityEstimator);
 };
 
 }  // namespace net
 
 #endif  // NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_