Expose changes in the network quality to the renderers

content/browser/net/network_quality_observer_impl.h

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.

[nasko, 2017/05/08 18:27:45]

No "(c)".

[tbansal1, 2017/05/08 19:50:19]

Done. I am not sure where I copied this from.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_NET_NETWORK_QUALITY_OBSERVER_IMPL_H_
+#define CONTENT_BROWSER_NET_NETWORK_QUALITY_OBSERVER_IMPL_H_
+
+#include "base/macros.h"
+#include "base/threading/thread_checker.h"
+#include "content/common/content_export.h"
+#include "content/public/browser/network_quality_observer_factory.h"
+#include "net/nqe/network_quality.h"
+#include "net/nqe/network_quality_estimator.h"
+
+namespace content {
+
+// Listens for changes to the network quality and manages sending updates to
+// each RenderProcess via mojo.
+class CONTENT_EXPORT NetworkQualityObserverImpl
+    : public net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver {
+ public:
+  explicit NetworkQualityObserverImpl(
+      net::NetworkQualityEstimator* network_quality_estimator);
+
+  ~NetworkQualityObserverImpl() override;
+
+ private:
+  class UIObserver;

[nasko, 2017/05/08 18:27:45]

UIObserver implies that it is observing some user interface, not the UI thread.
Maybe rename it to UiThreadObserver, so it is more explicit that it is about the
UI thread?

[tbansal1, 2017/05/08 19:50:19]

Done.

+
+  // net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver
+  // implementation:
+  void OnRTTOrThroughputEstimatesComputed(
+      base::TimeDelta http_rtt,
+      base::TimeDelta transport_rtt,
+      int32_t downstream_throughput_kbps) override;

[RyanSturm, 2017/05/08 17:37:20]

#include <stdint.h>
Not sure if you have to because this is an override.

[tbansal1, 2017/05/08 19:50:19]

Done.

+
+  // |ui_oberver_| is owned by |this|, and interacts with
+  // the render processes. It is created on the IO thread but afterwards, should
+  // only be accessed on the UI thread.
+  std::unique_ptr<UIObserver> ui_oberver_;

[RyanSturm, 2017/05/08 17:37:20]

#include <memory>

[tbansal1, 2017/05/08 19:50:19]

Done.

+
+  net::NetworkQualityEstimator* network_quality_estimator_;

[nasko, 2017/05/08 18:27:45]

Can you include a comment on how the lifetime of this member is related to the
lifetime of the object?

[tbansal1, 2017/05/08 19:50:19]

Done.

+
+  //  The network quality when the |ui_oberver_| was last notified.
+  net::nqe::internal::NetworkQuality last_notified_network_quality_;
+
+  base::ThreadChecker thread_checker_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkQualityObserverImpl);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_NET_NETWORK_QUALITY_OBSERVER_IMPL_H_