Chromium Code Reviews| Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc | 
| diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc | 
| index 87cb8c46e4e03162569518ce28d2ec39c9218c05..0de31064c0da3252563c0ae1f81147fe51d3e8c9 100644 | 
| --- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc | 
| +++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc | 
| @@ -155,9 +155,16 @@ void PageLoadMetricsObserverTestHarness::SimulateStartedResource( | 
| void PageLoadMetricsObserverTestHarness::SimulateLoadedResource( | 
| const ExtraRequestCompleteInfo& info) { | 
| + content::ResourceType resource_type = content::RESOURCE_TYPE_SCRIPT; | 
| 
 
Dmitry Titov
2017/05/18 02:28:10
Is this unrelated change?
 
Bryan McQuade
2017/05/23 05:00:01
jkarlin was mentioning some challenges in this are
 
Pete Williamson
2017/05/24 01:01:50
This is a bug that we need to fix to enable the ne
 
 | 
| + // To be able to find the resource in GetTrackerOrNullForRequest, | 
| + // we depend on using something else instead of a MAIN_FRAME resource, | 
| + // so pretend this resource is the "SCRIPT" type for simulated loading. | 
| + if (info.resource_type != content::RESOURCE_TYPE_MAIN_FRAME) | 
| + resource_type = info.resource_type; | 
| + | 
| observer_->OnRequestComplete( | 
| info.url, info.frame_tree_node_id, content::GlobalRequestID(), | 
| - info.resource_type, info.was_cached, | 
| + resource_type, info.was_cached, | 
| info.data_reduction_proxy_data | 
| ? info.data_reduction_proxy_data->DeepCopy() | 
| : nullptr, |