chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2857063002: Add a way to send the resource percentage signal to the RC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)

Patch Set: More RyanSturm feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 27a685cd1e6cd5a438095680643244c2fe470754..87cb8c46e4e03162569518ce28d2ec39c9218c05 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -157,7 +157,7 @@ void PageLoadMetricsObserverTestHarness::SimulateLoadedResource(

const ExtraRequestCompleteInfo& info) {

observer_->OnRequestComplete(

info.url, info.frame_tree_node_id, content::GlobalRequestID(),

- content::RESOURCE_TYPE_SCRIPT, info.was_cached,

+ info.resource_type, info.was_cached,

Pete Williamson 2017/05/10 23:43:36 It looks like this change breaks a lot of tests wh

info.data_reduction_proxy_data

? info.data_reduction_proxy_data->DeepCopy()

: nullptr,