Index: chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
diff --git a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
index 58e8d87861dccc8e9159af34fcad3797443fa0d7..9386b02379ba2dabe703aa74c3598fc0e10ed3dc 100644 |
--- a/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
+++ b/chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h |
@@ -8,13 +8,19 @@ |
#include <stdint.h> |
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" |
+#include "content/public/common/resource_type.h" |
+ |
+namespace offline_pages { |
+class ResourceTrackerObserver; |
+} |
namespace page_load_metrics { |
class ResourceTrackingPageLoadMetricsObserver |
: public page_load_metrics::PageLoadMetricsObserver { |
public: |
- ResourceTrackingPageLoadMetricsObserver(); |
+ ResourceTrackingPageLoadMetricsObserver( |
+ offline_pages::ResourceTrackerObserver* request_coordinator); |
~ResourceTrackingPageLoadMetricsObserver() override; |
// Called by the PageLoadMetrics framework when we start a new request, so we |
@@ -29,7 +35,8 @@ class ResourceTrackingPageLoadMetricsObserver |
void OnLoadedResource( |
const ExtraRequestCompleteInfo& extra_request_complete_info) override; |
- // For the specified type, get the count of requests started and completed. |
+ // For the specified type, get the count of requests started and |
+ // completed. |
// TODO(petewil) Note that type is not used yet, code to use it is coming |
// soon. |
void GetCountsForTypeForTesting(const content::ResourceType type, |
RyanSturm
2017/05/10 18:30:13
How are you planning on using this? I am a fan of
Pete Williamson
2017/05/10 19:00:52
This is only used from the unit test. I removed i
|
@@ -37,11 +44,18 @@ class ResourceTrackingPageLoadMetricsObserver |
int64_t* completed_count); |
private: |
+ void InformObservers(const content::ResourceType type, |
+ int64_t started_count, |
+ int64_t completed_count); |
+ |
// TODO(petewil): Some way to keep track of what we've seen |
// TODO(petewil): Some way to inform our keeper of aggregate results when they |
// change. |
int64_t started_count_; |
int64_t completed_count_; |
+ // Unowned pointer to the request_coordinator_, it will be valid for the |
RyanSturm
2017/05/10 18:30:13
nit: s/the request_coordinator_/the current profil
Pete Williamson
2017/05/10 19:00:52
Done.
|
+ // lifetime of the PageLoadMetricsObserver. |
+ offline_pages::ResourceTrackerObserver* request_coordinator_; |
}; |
} // namespace page_load_metrics |