Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)
Patch Set: CR Feedback per Dimich, BMcQuade, and CSHarrison Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
10 #if defined(OS_ANDROID) 10 #if defined(OS_ANDROID)
(...skipping 11 matching lines...) Expand all
22 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h" 22 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
23 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h" 23 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h"
24 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h" 24 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h"
25 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h" 25 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h"
26 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h" 26 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
27 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h" 27 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h"
28 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h" 28 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h"
29 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h" 29 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h"
30 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h" 30 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h"
31 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h" 31 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h"
32 #include "chrome/browser/page_load_metrics/observers/resource_tracking_page_load _metrics_observer.h"
32 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h" 33 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h"
33 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h" 34 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h"
34 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h" 35 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h"
35 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h" 36 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h"
36 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h" 37 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h"
37 #include "chrome/browser/page_load_metrics/page_load_tracker.h" 38 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
38 #include "chrome/browser/prerender/prerender_contents.h" 39 #include "chrome/browser/prerender/prerender_contents.h"
39 #include "chrome/browser/profiles/profile.h" 40 #include "chrome/browser/profiles/profile.h"
40 #include "chrome/browser/search/search.h" 41 #include "chrome/browser/search/search.h"
42 #include "components/offline_pages/core/background/offliner.h"
43 #include "components/offline_pages/features/features.h"
41 #include "components/rappor/rappor_service_impl.h" 44 #include "components/rappor/rappor_service_impl.h"
42 #include "content/public/browser/web_contents.h" 45 #include "content/public/browser/web_contents.h"
43 #include "url/gurl.h" 46 #include "url/gurl.h"
44 47
45 namespace chrome { 48 namespace chrome {
46 49
47 namespace { 50 namespace {
48 51
49 class PageLoadMetricsEmbedder 52 class PageLoadMetricsEmbedder
50 : public page_load_metrics::PageLoadMetricsEmbedderInterface { 53 : public page_load_metrics::PageLoadMetricsEmbedderInterface {
51 public: 54 public:
52 explicit PageLoadMetricsEmbedder(content::WebContents* web_contents); 55 explicit PageLoadMetricsEmbedder(content::WebContents* web_contents,
56 bool background_rendering);
53 ~PageLoadMetricsEmbedder() override; 57 ~PageLoadMetricsEmbedder() override;
54 58
55 // page_load_metrics::PageLoadMetricsEmbedderInterface: 59 // page_load_metrics::PageLoadMetricsEmbedderInterface:
56 bool IsNewTabPageUrl(const GURL& url) override; 60 bool IsNewTabPageUrl(const GURL& url) override;
57 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override; 61 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override;
58 62
59 private: 63 private:
60 bool IsPrerendering() const; 64 bool IsPrerendering() const;
61 65
62 content::WebContents* const web_contents_; 66 content::WebContents* const web_contents_;
67 // true when rendering in the background, such as creating an offline page.
68 bool background_rendering_;
63 69
64 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsEmbedder); 70 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsEmbedder);
65 }; 71 };
66 72
67 PageLoadMetricsEmbedder::PageLoadMetricsEmbedder( 73 PageLoadMetricsEmbedder::PageLoadMetricsEmbedder(
68 content::WebContents* web_contents) 74 content::WebContents* web_contents,
69 : web_contents_(web_contents) {} 75 bool background_rendering)
76 : web_contents_(web_contents),
77 background_rendering_(background_rendering) {}
70 78
71 PageLoadMetricsEmbedder::~PageLoadMetricsEmbedder() {} 79 PageLoadMetricsEmbedder::~PageLoadMetricsEmbedder() {}
72 80
73 void PageLoadMetricsEmbedder::RegisterObservers( 81 void PageLoadMetricsEmbedder::RegisterObservers(
74 page_load_metrics::PageLoadTracker* tracker) { 82 page_load_metrics::PageLoadTracker* tracker) {
75 if (!IsPrerendering()) { 83 if (!IsPrerendering() && !background_rendering_) {
76 tracker->AddObserver(base::MakeUnique<AbortsPageLoadMetricsObserver>()); 84 tracker->AddObserver(base::MakeUnique<AbortsPageLoadMetricsObserver>());
77 tracker->AddObserver(base::MakeUnique<AMPPageLoadMetricsObserver>()); 85 tracker->AddObserver(base::MakeUnique<AMPPageLoadMetricsObserver>());
78 tracker->AddObserver(base::MakeUnique<CorePageLoadMetricsObserver>()); 86 tracker->AddObserver(base::MakeUnique<CorePageLoadMetricsObserver>());
79 tracker->AddObserver( 87 tracker->AddObserver(
80 base::MakeUnique< 88 base::MakeUnique<
81 data_reduction_proxy::DataReductionProxyMetricsObserver>()); 89 data_reduction_proxy::DataReductionProxyMetricsObserver>());
82 tracker->AddObserver( 90 tracker->AddObserver(
83 base::MakeUnique<data_reduction_proxy::LoFiPageLoadMetricsObserver>()); 91 base::MakeUnique<data_reduction_proxy::LoFiPageLoadMetricsObserver>());
84 tracker->AddObserver(base::MakeUnique<FromGWSPageLoadMetricsObserver>()); 92 tracker->AddObserver(base::MakeUnique<FromGWSPageLoadMetricsObserver>());
85 tracker->AddObserver( 93 tracker->AddObserver(
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> 136 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
129 prerender_observer = 137 prerender_observer =
130 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_); 138 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_);
131 if (prerender_observer) 139 if (prerender_observer)
132 tracker->AddObserver(std::move(prerender_observer)); 140 tracker->AddObserver(std::move(prerender_observer));
133 } 141 }
134 tracker->AddObserver( 142 tracker->AddObserver(
135 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering())); 143 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering()));
136 tracker->AddObserver( 144 tracker->AddObserver(
137 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>()); 145 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>());
146 #if BUILDFLAG(ENABLE_OFFLINE_PAGES)
147 if (background_rendering_) {
148 tracker->AddObserver(
149 base::MakeUnique<
150 page_load_metrics::ResourceTrackingPageLoadMetricsObserver>());
151 }
152 #endif // ENABLE_OFFLINE_PAGES
138 } 153 }
139 154
140 bool PageLoadMetricsEmbedder::IsPrerendering() const { 155 bool PageLoadMetricsEmbedder::IsPrerendering() const {
141 return prerender::PrerenderContents::FromWebContents(web_contents_) != 156 return prerender::PrerenderContents::FromWebContents(web_contents_) !=
142 nullptr; 157 nullptr;
143 } 158 }
144 159
145 bool PageLoadMetricsEmbedder::IsNewTabPageUrl(const GURL& url) { 160 bool PageLoadMetricsEmbedder::IsNewTabPageUrl(const GURL& url) {
146 Profile* profile = 161 Profile* profile =
147 Profile::FromBrowserContext(web_contents_->GetBrowserContext()); 162 Profile::FromBrowserContext(web_contents_->GetBrowserContext());
148 if (!profile) 163 if (!profile)
149 return false; 164 return false;
150 return search::IsInstantNTPURL(url, profile); 165 return search::IsInstantNTPURL(url, profile);
151 } 166 }
152 167
153 } // namespace 168 } // namespace
154 169
155 void InitializePageLoadMetricsForWebContents( 170 void InitializePageLoadMetricsForWebContents(content::WebContents* web_contents,
156 content::WebContents* web_contents) { 171 bool background_rendering) {
157 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents( 172 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
158 web_contents, base::MakeUnique<PageLoadMetricsEmbedder>(web_contents)); 173 web_contents, base::MakeUnique<PageLoadMetricsEmbedder>(
174 web_contents, background_rendering));
159 } 175 }
160 176
161 } // namespace chrome 177 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698