Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2857063002: Add a way to send the resource percentage signal to the RC. (Closed)
Patch Set: Turn off other metrics which might require tab helpers when background loading Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #if defined(OS_ANDROID)
10 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
11 #endif
9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 12 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
10 #if defined(OS_ANDROID) 13 #if defined(OS_ANDROID)
11 #include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_o bserver.h" 14 #include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_o bserver.h"
12 #endif // OS_ANDROID 15 #endif // OS_ANDROID
13 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 16 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
14 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_obser ver.h" 17 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_obser ver.h"
15 #include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_obser ver.h" 18 #include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_obser ver.h"
16 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 19 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
17 #include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metr ics_observer.h" 20 #include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metr ics_observer.h"
18 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metric s_observer.h" 21 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metric s_observer.h"
19 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h" 22 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h"
20 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 23 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
21 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h" 24 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h"
22 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h" 25 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
23 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h" 26 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/ht tps_engagement_page_load_metrics_observer.h"
24 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h" 27 #include "chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_obse rver.h"
25 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h" 28 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_obs erver.h"
26 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h" 29 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
27 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h" 30 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_pag e_load_metrics_observer.h"
28 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h" 31 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h"
29 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h" 32 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h"
30 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h" 33 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_ observer.h"
31 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h" 34 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h"
35 #include "chrome/browser/page_load_metrics/observers/resource_tracking_page_load _metrics_observer.h"
32 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h" 36 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_me trics_observer.h"
33 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h" 37 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h"
34 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h" 38 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metri cs_observer.h"
35 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h" 39 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h"
36 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h" 40 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface. h"
37 #include "chrome/browser/page_load_metrics/page_load_tracker.h" 41 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
38 #include "chrome/browser/prerender/prerender_contents.h" 42 #include "chrome/browser/prerender/prerender_contents.h"
39 #include "chrome/browser/profiles/profile.h" 43 #include "chrome/browser/profiles/profile.h"
40 #include "chrome/browser/search/search.h" 44 #include "chrome/browser/search/search.h"
45 #include "components/offline_pages/core/background/request_coordinator.h"
46 #include "components/offline_pages/features/features.h"
41 #include "components/rappor/rappor_service_impl.h" 47 #include "components/rappor/rappor_service_impl.h"
42 #include "content/public/browser/web_contents.h" 48 #include "content/public/browser/web_contents.h"
43 #include "url/gurl.h" 49 #include "url/gurl.h"
44 50
45 namespace chrome { 51 namespace chrome {
46 52
47 namespace { 53 namespace {
48 54
49 class PageLoadMetricsEmbedder 55 class PageLoadMetricsEmbedder
50 : public page_load_metrics::PageLoadMetricsEmbedderInterface { 56 : public page_load_metrics::PageLoadMetricsEmbedderInterface {
51 public: 57 public:
52 explicit PageLoadMetricsEmbedder(content::WebContents* web_contents); 58 explicit PageLoadMetricsEmbedder(content::WebContents* web_contents,
59 bool background_rendering);
53 ~PageLoadMetricsEmbedder() override; 60 ~PageLoadMetricsEmbedder() override;
54 61
55 // page_load_metrics::PageLoadMetricsEmbedderInterface: 62 // page_load_metrics::PageLoadMetricsEmbedderInterface:
56 bool IsNewTabPageUrl(const GURL& url) override; 63 bool IsNewTabPageUrl(const GURL& url) override;
57 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override; 64 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override;
58 65
59 private: 66 private:
60 bool IsPrerendering() const; 67 bool IsPrerendering() const;
61 68
62 content::WebContents* const web_contents_; 69 content::WebContents* const web_contents_;
70 // true when rendering in the background, such as creating an offline page.
71 bool background_rendering_;
63 72
64 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsEmbedder); 73 DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsEmbedder);
65 }; 74 };
66 75
67 PageLoadMetricsEmbedder::PageLoadMetricsEmbedder( 76 PageLoadMetricsEmbedder::PageLoadMetricsEmbedder(
68 content::WebContents* web_contents) 77 content::WebContents* web_contents,
69 : web_contents_(web_contents) {} 78 bool background_rendering)
79 : web_contents_(web_contents),
80 background_rendering_(background_rendering) {}
70 81
71 PageLoadMetricsEmbedder::~PageLoadMetricsEmbedder() {} 82 PageLoadMetricsEmbedder::~PageLoadMetricsEmbedder() {}
72 83
73 void PageLoadMetricsEmbedder::RegisterObservers( 84 void PageLoadMetricsEmbedder::RegisterObservers(
74 page_load_metrics::PageLoadTracker* tracker) { 85 page_load_metrics::PageLoadTracker* tracker) {
75 if (!IsPrerendering()) { 86 if (!IsPrerendering() && !background_rendering_) {
76 tracker->AddObserver(base::MakeUnique<AbortsPageLoadMetricsObserver>()); 87 tracker->AddObserver(base::MakeUnique<AbortsPageLoadMetricsObserver>());
77 tracker->AddObserver(base::MakeUnique<AMPPageLoadMetricsObserver>()); 88 tracker->AddObserver(base::MakeUnique<AMPPageLoadMetricsObserver>());
78 tracker->AddObserver(base::MakeUnique<CorePageLoadMetricsObserver>()); 89 tracker->AddObserver(base::MakeUnique<CorePageLoadMetricsObserver>());
79 tracker->AddObserver( 90 tracker->AddObserver(
80 base::MakeUnique< 91 base::MakeUnique<
81 data_reduction_proxy::DataReductionProxyMetricsObserver>()); 92 data_reduction_proxy::DataReductionProxyMetricsObserver>());
82 tracker->AddObserver( 93 tracker->AddObserver(
83 base::MakeUnique<data_reduction_proxy::LoFiPageLoadMetricsObserver>()); 94 base::MakeUnique<data_reduction_proxy::LoFiPageLoadMetricsObserver>());
84 tracker->AddObserver(base::MakeUnique<FromGWSPageLoadMetricsObserver>()); 95 tracker->AddObserver(base::MakeUnique<FromGWSPageLoadMetricsObserver>());
85 tracker->AddObserver( 96 tracker->AddObserver(
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> 139 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
129 prerender_observer = 140 prerender_observer =
130 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_); 141 PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_);
131 if (prerender_observer) 142 if (prerender_observer)
132 tracker->AddObserver(std::move(prerender_observer)); 143 tracker->AddObserver(std::move(prerender_observer));
133 } 144 }
134 tracker->AddObserver( 145 tracker->AddObserver(
135 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering())); 146 base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering()));
136 tracker->AddObserver( 147 tracker->AddObserver(
137 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>()); 148 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>());
149 #if BUILDFLAG(ENABLE_OFFLINE_PAGES)
150 if (background_rendering_) {
151 offline_pages::RequestCoordinator* request_coordinator =
152 offline_pages::RequestCoordinatorFactory::GetForBrowserContext(
153 web_contents_->GetBrowserContext());
154 if (request_coordinator) {
155 tracker->AddObserver(
156 base::MakeUnique<
157 page_load_metrics::ResourceTrackingPageLoadMetricsObserver>(
158 request_coordinator));
159 }
160 }
161 #endif // ENABLE_OFFLINE_PAGES
138 } 162 }
139 163
140 bool PageLoadMetricsEmbedder::IsPrerendering() const { 164 bool PageLoadMetricsEmbedder::IsPrerendering() const {
141 return prerender::PrerenderContents::FromWebContents(web_contents_) != 165 return prerender::PrerenderContents::FromWebContents(web_contents_) !=
142 nullptr; 166 nullptr;
143 } 167 }
144 168
145 bool PageLoadMetricsEmbedder::IsNewTabPageUrl(const GURL& url) { 169 bool PageLoadMetricsEmbedder::IsNewTabPageUrl(const GURL& url) {
146 Profile* profile = 170 Profile* profile =
147 Profile::FromBrowserContext(web_contents_->GetBrowserContext()); 171 Profile::FromBrowserContext(web_contents_->GetBrowserContext());
148 if (!profile) 172 if (!profile)
149 return false; 173 return false;
150 return search::IsInstantNTPURL(url, profile); 174 return search::IsInstantNTPURL(url, profile);
151 } 175 }
152 176
153 } // namespace 177 } // namespace
154 178
155 void InitializePageLoadMetricsForWebContents( 179 void InitializePageLoadMetricsForWebContents(content::WebContents* web_contents,
156 content::WebContents* web_contents) { 180 bool background_rendering) {
157 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents( 181 page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
158 web_contents, base::MakeUnique<PageLoadMetricsEmbedder>(web_contents)); 182 web_contents, base::MakeUnique<PageLoadMetricsEmbedder>(
183 web_contents, background_rendering));
159 } 184 }
160 185
161 } // namespace chrome 186 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698