Add a way to send the resource percentage signal to the RC.

chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"
 
+#include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
+#if defined(OS_ANDROID)
+#include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
+#endif
 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
 #if defined(OS_ANDROID)
 #include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"
 #endif  // OS_ANDROID
 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"
 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
+#if defined(OS_ANDROID)
+#include "components/offline_pages/core/background/request_coordinator.h"
+#endif
 #include "components/rappor/rappor_service_impl.h"
 #include "content/public/browser/web_contents.h"
 #include "url/gurl.h"
 
 namespace chrome {
 
 namespace {
 
 class PageLoadMetricsEmbedder
     : public page_load_metrics::PageLoadMetricsEmbedderInterface {
@@ skipping 75 matching lines @@
     std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
         prerender_observer =
             PrerenderPageLoadMetricsObserver::CreateIfNeeded(web_contents_);
     if (prerender_observer)
       tracker->AddObserver(std::move(prerender_observer));
   }
   tracker->AddObserver(
       base::MakeUnique<OmniboxSuggestionUsedMetricsObserver>(IsPrerendering()));
   tracker->AddObserver(
       base::MakeUnique<DelayNavigationPageLoadMetricsObserver>());
+#if defined(OS_ANDROID)
+  // Whether we are using the pre-renderer or not, set up a
+  // ResourceTrackingPageLoadMetricsObserver.
+  offline_pages::RequestCoordinator* request_coordinator =

[RyanSturm, 2017/05/10 15:55:53]

Can you move the code to get the RequestCoordinator into OnStart of
ResourceTrackingPageLoadMetricsObserver (it's called on the same stack as the
constructor).

[Pete Williamson, 2017/05/10 18:14:53]

I originally did this for dependency injection to make the code more testable. 
I can change it as you suggest, but then I'm not sure how to unit test the
ResourceTrackingPageLoadMetricsObserver - do you know any techniques to mock out
getting a keyed service in a unit test?  I would think it required enough of
chrome to be a full browser test at that point.

[RyanSturm, 2017/05/10 18:30:13]

That's a valid point. I've done some other hacky approaches here using
virtualization:
https://cs.chromium.org/chromium/src/chrome/browser/page_load_metrics/observe...

If you are more comfortable with that approach, it keeps the boundaries a little
more clear. Generally, I agree dependency injection is better though, so I won't
push back.

+      offline_pages::RequestCoordinatorFactory::GetForBrowserContext(
+          web_contents_->GetBrowserContext());
+  if (request_coordinator) {
+    tracker->AddObserver(
+        base::MakeUnique<
+            page_load_metrics::ResourceTrackingPageLoadMetricsObserver>(
+            request_coordinator));
+  }
+#endif  // OS_ANDROID
 }
 
 bool PageLoadMetricsEmbedder::IsPrerendering() const {
   return prerender::PrerenderContents::FromWebContents(web_contents_) !=
          nullptr;
 }
 
 bool PageLoadMetricsEmbedder::IsNewTabPageUrl(const GURL& url) {
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   if (!profile)
     return false;
   return search::IsInstantNTPURL(url, profile);
 }
 
 }  // namespace
 
 void InitializePageLoadMetricsForWebContents(
     content::WebContents* web_contents) {
   page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
       web_contents, base::MakeUnique<PageLoadMetricsEmbedder>(web_contents));
 }
 
 }  // namespace chrome