Return early after errors in glVertexAttribDivisor and glCopyTexImage2D implementations

Return early after errors in glVertexAttribDivisor and glCopyTexImage2D implementations

Command buffer command decoder is missing few early returns.  Add early
returns after error handling in glVertexAttribDivisorANGLE if no
extension is present and glCopyTexImage2D if texture is immutable.

BUG=373159
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272424

[vmiura, 2014-05-21 04:56:57]

LGTM, thanks for this.  Mind adding them to
GLES2DecoderImpl::HandleLoseContextCHROMIUM() also?

https://chromiumcodereview.appspot.com/285703005/diff/20001/gpu/command_buffe...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://chromiumcodereview.appspot.com/285703005/diff/20001/gpu/command_buffe...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9484: "glLoseContextCHROMIUM",
current, "current");
Here too.

https://chromiumcodereview.appspot.com/285703005/diff/20001/gpu/command_buffe...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9487:
LOCAL_SET_GL_ERROR_INVALID_ENUM("glLoseContextCHROMIUM", other, "other");
Here too.

[Kimmo Kinnunen, 2014-05-21 07:15:40]

https://chromiumcodereview.appspot.com/285703005/diff/20001/gpu/command_buffe...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://chromiumcodereview.appspot.com/285703005/diff/20001/gpu/command_buffe...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9484: "glLoseContextCHROMIUM",
current, "current");
On 2014/05/21 04:56:57, vmiura wrote:
> Here too.

There seems to be a bug wrt lose context error state. I'd rather fix that in a
separate patch.

[zmo, 2014-05-21 16:59:37]

LGTM
Thanks for fixing this.

[piman, 2014-05-21 17:00:34]

https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9453: "glLoseContextCHROMIUM",
current, "current");
return here too?

https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9456:
LOCAL_SET_GL_ERROR_INVALID_ENUM("glLoseContextCHROMIUM", other, "other");
And here?

[zmo, 2014-05-21 17:01:40]

On 2014/05/21 17:00:34, piman wrote:
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9453: "glLoseContextCHROMIUM",
> current, "current");
> return here too?
> 
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9456:
> LOCAL_SET_GL_ERROR_INVALID_ENUM("glLoseContextCHROMIUM", other, "other");
> And here?

See his earlier reply.  He wants to fix it separately.

[piman, 2014-05-21 17:01:56]

On 2014/05/21 17:00:34, piman wrote:
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9453: "glLoseContextCHROMIUM",
> current, "current");
> return here too?
> 
>
https://chromiumcodereview.appspot.com/285703005/diff/40001/gpu/command_buffe...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9456:
> LOCAL_SET_GL_ERROR_INVALID_ENUM("glLoseContextCHROMIUM", other, "other");
> And here?

Sorry, missed previous comments.
LGTM for now if this is going to a follow-up.

[Kimmo Kinnunen, 2014-05-22 05:15:14]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-22 05:18:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/285703005/40001

[commit-bot: I haz the power, 2014-05-22 14:34:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 14:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:36:37]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Kimmo Kinnunen, 2014-05-23 05:53:45]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-23 05:54:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/285703005/40001

[commit-bot: I haz the power, 2014-05-23 07:08:04]

Change committed as 272424