Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2857030: Exhaustive test for rollback code (Closed)

Created:
10 years, 5 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson
Base URL:
ssh://git@chromiumos-git/vboot_reference.git
Visibility:
Public.

Description

This test sets the TPM to a each of a large amount of "interesting" initial states, and runs the firmware code at user level. This code compiles and installs using a modified ebuild (which needs to be committed after this change).

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 22

Patch Set 5 : More fixes. #

Patch Set 6 : Add upstart script for fully automated testing. #

Patch Set 7 : tweaks and some refactoring #

Patch Set 8 : Refactoring one large ugly function. #

Patch Set 9 : wait for localhost to be ready, and keep iterating is link is down #

Patch Set 10 : whitespace #

Patch Set 11 : more comments #

Total comments: 5

Patch Set 12 : Fix write count handling and improve comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+858 lines, -29 lines) Patch
M Makefile View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M firmware/Makefile View 1 chunk +3 lines, -3 lines 0 comments Download
M firmware/include/tlcl.h View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M firmware/lib/include/rollback_index.h View 1 chunk +9 lines, -0 lines 0 comments Download
M firmware/lib/include/tss_constants.h View 1 chunk +3 lines, -1 line 0 comments Download
M firmware/lib/rollback_index.c View 1 2 3 4 7 chunks +16 lines, -11 lines 0 comments Download
M firmware/linktest/main.c View 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M firmware/stub/tlcl.c View 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M firmware/version.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/Makefile View 1 2 3 4 4 chunks +24 lines, -12 lines 0 comments Download
A tests/rbtest.conf View 6 7 8 9 10 11 1 chunk +34 lines, -0 lines 0 comments Download
A tests/rollback_index_test.c View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +749 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Luigi Semenzato
This is the initial version of the rollback test. It probably still has bugs, but ...
10 years, 5 months ago (2010-07-01 22:11:32 UTC) #1
gauravsh
your patch seems to have picked up changes from your previous CLs. Did you run ...
10 years, 5 months ago (2010-07-01 23:10:05 UTC) #2
gauravsh
i know this is work in progress - but here is some initial bit of ...
10 years, 5 months ago (2010-07-02 01:52:50 UTC) #3
Luigi Semenzato
Still WIP. This already fixes some problems with the rollback_index code that were revealed while ...
10 years, 5 months ago (2010-07-02 22:53:32 UTC) #4
Luigi Semenzato
PTAL. The test seems to be running fine on a couple of ST8s. The test ...
10 years, 5 months ago (2010-07-08 00:09:08 UTC) #5
gauravsh
lgtm with comments about comments http://codereview.chromium.org/2857030/diff/6001/7010 File tests/rollback_index_test.c (right): http://codereview.chromium.org/2857030/diff/6001/7010#newcode31 tests/rollback_index_test.c:31: #define RETURN_ON_FAILURE(tpm_command) do { ...
10 years, 5 months ago (2010-07-08 02:24:44 UTC) #6
Luigi Semenzato
Thank you for the review. I will add some clarifications and push. http://codereview.chromium.org/2857030/diff/6001/7010 File tests/rollback_index_test.c ...
10 years, 5 months ago (2010-07-08 15:16:51 UTC) #7
gauravsh
On Thu, Jul 8, 2010 at 8:16 AM, <semenzato@chromium.org> wrote: > Thank you for the ...
10 years, 5 months ago (2010-07-08 16:40:17 UTC) #8
Luigi Semenzato
Name resolution is a likely cause. Unfortunately there is no configuration option for trousers to ...
10 years, 5 months ago (2010-07-08 16:48:12 UTC) #9
Nathan Williams
http://codereview.chromium.org/2857030/diff/30001/31010 File tests/rbtest.conf (right): http://codereview.chromium.org/2857030/diff/30001/31010#newcode15 tests/rbtest.conf:15: # Connecting to tcsd requires networking. On 2010/07/08 15:16:51, ...
10 years, 5 months ago (2010-07-08 17:42:46 UTC) #10
Nathan Williams
10 years, 5 months ago (2010-07-08 17:42:49 UTC) #11
Luigi Semenzato
On 2010/07/08 17:42:46, Nathan Williams wrote: > http://codereview.chromium.org/2857030/diff/30001/31010 > File tests/rbtest.conf (right): > > http://codereview.chromium.org/2857030/diff/30001/31010#newcode15 ...
10 years, 5 months ago (2010-07-08 17:54:38 UTC) #12
Luigi Semenzato
It's unclear this change will ever be useful, but it is certainly more paranoid than ...
10 years, 5 months ago (2010-07-08 18:03:29 UTC) #13
Luigi Semenzato
10 years, 5 months ago (2010-07-08 18:03:57 UTC) #14
On 2010/07/08 18:03:29, Luigi Semenzato wrote:
> It's unclear this change will ever be useful, but it is certainly more
paranoid
> than before, which is a good thing, I think.

Oops, sorry, I commented on the wrong CL.

Powered by Google App Engine
This is Rietveld 408576698