[Remoting iOS] Basic viewport manipulation support

remoting/client/ios/display/gl_display_handler.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_IOS_DISPLAY_GL_DISPLAY_HANDLER_H_
 #define REMOTING_CLIENT_IOS_DISPLAY_GL_DISPLAY_HANDLER_H_
 
 #import <Foundation/Foundation.h>
 #import <GLKit/GLKit.h>
-
-#import "remoting/client/display/sys_opengl.h"
+#include <array>

[nicholss, 2017/05/03 22:47:35]

new line between #import and include
 
Where are you using array in the .h file?

[Yuwei, 2017/05/04 00:28:07]

Removed. Not used anymore.

 
 #include "base/memory/ptr_util.h"
+#import "remoting/client/display/sys_opengl.h"

[nicholss, 2017/05/03 22:47:35]

sort the includes, #imports first

[Yuwei, 2017/05/04 00:28:07]

Done.

+#include "remoting/client/view_matrix.h"
 
 namespace remoting {
 
 class ChromotingClientRuntime;
 
 namespace protocol {
 
 class VideoRenderer;
 class CursorShapeStub;
 
 }  // namespace protocol
 }  // namespace remoting
 
+@protocol GlDisplayHandlerDelegate<NSObject>

[nicholss, 2017/05/03 22:47:35]

Can you also add a comment describing the what the goal of the delegate is?

[Yuwei, 2017/05/04 00:28:07]

Done.

+
+// Notifies the delegate that the size of the desktop image has changed.
+- (void)canvasSizeChanged:(CGSize)size;
+
+@end
+
 @interface GlDisplayHandler : NSObject {
 }
 
 - (void)stop;
 
+- (void)setDelegate:(id<GlDisplayHandlerDelegate>)delegate;

[nicholss, 2017/05/03 22:47:35]

Better to use @property delegate, for example:
https://cs.chromium.org/chromium/src/remoting/client/ios/key_input.h?type=cs&...

And then you can still call setDelegate but you really should use
object.delegate = someDelegate;

[Yuwei, 2017/05/04 00:28:07]

Done. Manually synthesized with trick to disable the getter. ObjC doesn't
support write-only @property...

+
 // Called once the GLKView created.
 - (void)onSurfaceCreated:(GLKView*)view;
 
 // Called every time the GLKView dimension is initialized or changed.
 - (void)onSurfaceChanged:(const CGRect&)frame;
 
+- (void)onPixelTransformationChanged:(const remoting::ViewMatrix&)matrix;
+
 - (std::unique_ptr<remoting::protocol::VideoRenderer>)CreateVideoRenderer;
 - (std::unique_ptr<remoting::protocol::CursorShapeStub>)CreateCursorShapeStub;
 
 - (EAGLContext*)GetEAGLContext;
 
 @end
 
 #endif  // REMOTING_CLIENT_IOS_DISPLAY_GL_DISPLAY_HANDLER_H_