src/liveedit.cc - Issue 285693006: Fix Heap::IsHeapIterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 285693006: Fix Heap::IsHeapIterable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rename EnsureHeapIsIterable => MakeHeapIterable Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index e6bb4b29a636297d25d1d69c9ca7ff3a7b1edb52..df8b64b3ac86f0b3490a58f9bb5086ec3d15ccaf 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1165,7 +1165,7 @@ void LiveEdit::ReplaceFunctionCode(

Handle<SharedFunctionInfo> shared_info = shared_info_wrapper.GetInfo();

- isolate->heap()->EnsureHeapIsIterable();

+ isolate->heap()->MakeHeapIterable();

if (IsJSFunctionCode(shared_info->code())) {

Handle<Code> code = compile_info_wrapper.GetFunctionCode();

@@ -1402,7 +1402,7 @@ void LiveEdit::PatchFunctionPositions(Handle<JSArray> shared_info_array,

info->set_end_position(new_function_end);

info->set_function_token_position(new_function_token_pos);

- info->GetIsolate()->heap()->EnsureHeapIsIterable();

+ info->GetIsolate()->heap()->MakeHeapIterable();

if (IsJSFunctionCode(info->code())) {

// Patch relocation info section of the code.

« src/heap.cc ('K') | « src/heap.cc ('k') | src/runtime.cc » ('j') | no next file with comments »