src/heap.h - Issue 285693006: Fix Heap::IsHeapIterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 285693006: Fix Heap::IsHeapIterable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rename EnsureHeapIsIterable => MakeHeapIterable Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.h

diff --git a/src/heap.h b/src/heap.h

index 8e3cd3f2b05724860dea12d18b3a1329701b210d..33889495e80f0810ce6300e83a44b4459b4bc0b3 100644

--- a/src/heap.h

+++ b/src/heap.h

@@ -762,12 +762,9 @@ class Heap {

// Last hope GC, should try to squeeze as much as possible.

void CollectAllAvailableGarbage(const char* gc_reason = NULL);

- // Check whether the heap is currently iterable.

- bool IsHeapIterable();

// Ensure that we have swept all spaces in such a way that we can iterate

// over all objects. May cause a GC.

- void EnsureHeapIsIterable();

+ void MakeHeapIterable();

Hannes Payer (out of office) 2014/05/19 08:31:12 I would call it MakeIterable, since it is a method

// Notify the heap that a context has been disposed.

int NotifyContextDisposed();

« no previous file with comments | « src/debug.cc ('k') | src/heap.cc » ('j') | src/heap.cc » ('J')