src/heap.cc - Issue 285693006: Fix Heap::IsHeapIterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 285693006: Fix Heap::IsHeapIterable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index f0c9154b5e9aa15cb45f00df5b5e43533b966979..8119eaf61395f93abfeec7c92dabff320b7eec28 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -4307,18 +4307,9 @@ STRUCT_LIST(MAKE_CASE)

}

-bool Heap::IsHeapIterable() {

- return (!old_pointer_space()->was_swept_conservatively() &&

- !old_data_space()->was_swept_conservatively());

void Heap::EnsureHeapIsIterable() {

Hannes Payer (out of office) 2014/05/18 18:25:43 Let's rename it to MakeIterable.

Jarin 2014/05/19 06:06:42 Done.

ASSERT(AllowHeapAllocation::IsAllowed());

- if (!IsHeapIterable()) {

- CollectAllGarbage(kMakeHeapIterableMask, "Heap::EnsureHeapIsIterable");

- }

- ASSERT(IsHeapIterable());

+ CollectAllGarbage(kMakeHeapIterableMask, "Heap::EnsureHeapIsIterable");

}

« no previous file with comments | « src/heap.h ('k') | src/runtime.cc » ('j') | src/runtime.cc » ('J')