Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2856913004: [Fuchsia] Allows non-regular files to be opened. (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
abarth, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Allows non-regular files to be opened. Fuchsia has lots of different file types that aren't covered by all of the things that stat() understands, so we have to switch to blacklisting directories. See the discussion on https://codereview.chromium.org/2844493004/ R=abarth@google.com Committed: https://github.com/dart-lang/sdk/commit/4b4b8e8783937175e4ecdc3bfacd7fd1cfbdc8da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M runtime/bin/file_fuchsia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zra
3 years, 7 months ago (2017-05-02 21:27:40 UTC) #3
abarth
lgtm
3 years, 7 months ago (2017-05-02 21:41:24 UTC) #5
abarth
Thanks!
3 years, 7 months ago (2017-05-02 21:41:30 UTC) #6
zra
3 years, 7 months ago (2017-05-02 21:47:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b4b8e8783937175e4ecdc3bfacd7fd1cfbdc8da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698