Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2856893002: Create NullLiteral using AstFactory in BodyBuilder. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create NullLiteral using AstFactory in BodyBuilder. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3820e630cabd6819f73cbaee13245276f02ea14e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-02 13:51:50 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-02 14:27:28 UTC) #2
scheglov
3 years, 7 months ago (2017-05-03 15:38:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3820e630cabd6819f73cbaee13245276f02ea14e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698