Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: components/history/core/browser/history_backend_unittest.cc

Issue 2856873002: [Thumbnails DB] Allow setting last_requested time when accessing favicons. (Closed)
Patch Set: Filter out bookmarks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_backend_unittest.cc
diff --git a/components/history/core/browser/history_backend_unittest.cc b/components/history/core/browser/history_backend_unittest.cc
index 9a72cb5706005afd445fd69e524128647de51577..8881f1dac5641e94cd8ff4fa725cf81491e65f89 100644
--- a/components/history/core/browser/history_backend_unittest.cc
+++ b/components/history/core/browser/history_backend_unittest.cc
@@ -1928,10 +1928,12 @@ TEST_F(HistoryBackendTest, SetFaviconsDeleteBitmaps) {
scoped_refptr<base::RefCountedMemory> bitmap_data_out;
gfx::Size pixel_size_out;
- EXPECT_FALSE(backend_->thumbnail_db_->GetFaviconBitmap(small_bitmap_id,
- NULL, NULL, &bitmap_data_out, &pixel_size_out));
- EXPECT_TRUE(backend_->thumbnail_db_->GetFaviconBitmap(large_bitmap_id,
- NULL, NULL, &bitmap_data_out, &pixel_size_out));
+ EXPECT_FALSE(backend_->thumbnail_db_->GetFaviconBitmap(
+ small_bitmap_id, /*access_time=*/base::Time::Now(), NULL,
+ &bitmap_data_out, &pixel_size_out));
+ EXPECT_TRUE(backend_->thumbnail_db_->GetFaviconBitmap(
+ large_bitmap_id, /*access_time=*/base::Time::Now(), NULL,
+ &bitmap_data_out, &pixel_size_out));
EXPECT_TRUE(BitmapColorEqual(SK_ColorWHITE, bitmap_data_out));
EXPECT_EQ(kLargeSize, pixel_size_out);

Powered by Google App Engine
This is Rietveld 408576698