Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/history/core/browser/android/favicon_sql_handler.cc

Issue 2856873002: [Thumbnails DB] Allow setting last_requested time when accessing favicons. (Closed)
Patch Set: Peter's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/android/favicon_sql_handler.cc
diff --git a/components/history/core/browser/android/favicon_sql_handler.cc b/components/history/core/browser/android/favicon_sql_handler.cc
index dd7a094ea609b847807b62f785ed2a476e95f180..b630bae4ea3c1a9749d04eae5086011cef12d3b8 100644
--- a/components/history/core/browser/android/favicon_sql_handler.cc
+++ b/components/history/core/browser/android/favicon_sql_handler.cc
@@ -39,7 +39,8 @@ bool FaviconSQLHandler::Update(const HistoryAndBookmarkRow& row,
// icon is already in database, just create a new favicon.
// TODO(pkotwicz): Pass in real pixel size.
favicon_base::FaviconID favicon_id = thumbnail_db_->AddFavicon(
- GURL(), favicon_base::FAVICON, row.favicon(), Time::Now(), gfx::Size());
+ GURL(), favicon_base::FAVICON, row.favicon(), FaviconBitmapType::ON_VISIT,
+ Time::Now(), gfx::Size());
if (!favicon_id)
return false;
@@ -104,7 +105,8 @@ bool FaviconSQLHandler::Insert(HistoryAndBookmarkRow* row) {
// Is it a problem to give a empty URL?
// TODO(pkotwicz): Pass in real pixel size.
favicon_base::FaviconID id = thumbnail_db_->AddFavicon(
- GURL(), favicon_base::FAVICON, row->favicon(), Time::Now(), gfx::Size());
+ GURL(), favicon_base::FAVICON, row->favicon(),
+ FaviconBitmapType::ON_VISIT, Time::Now(), gfx::Size());
if (!id)
return false;
return thumbnail_db_->AddIconMapping(row->url(), id);
« no previous file with comments | « components/favicon/core/test/mock_favicon_service.h ('k') | components/history/core/browser/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698