Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Issue 2856863009: Remove status entries for now-passing checked-mode co19 tests that were returning a value from a vo… (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, terry, floitsch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove status entries for now-passing checked-mode co19 tests that were returning a value from a void function BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/47ba2bd413e56a5bba71780c0c7a256322693476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tests/co19/co19-dartium.status View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Alan Knight
Failures from https://codereview.chromium.org/2718513002
3 years, 7 months ago (2017-05-04 19:56:22 UTC) #2
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-04 19:57:10 UTC) #3
Alan Knight
Committed patchset #1 (id:1) manually as 47ba2bd413e56a5bba71780c0c7a256322693476 (presubmit successful).
3 years, 7 months ago (2017-05-04 19:59:58 UTC) #5
floitsch
3 years, 7 months ago (2017-05-06 17:46:55 UTC) #7
Message was sent while issue was closed.
This CL was reverted in d9e93a106705d211fd5e66a53c4687b33b2d5261 and is now part
of https://codereview.chromium.org/2718513002/

Powered by Google App Engine
This is Rietveld 408576698