Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2856863006: [Devtools] Fix network grouping experiment (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
836 continue; 836 continue;
837 var isFilteredOut = !this._applyFilter(node); 837 var isFilteredOut = !this._applyFilter(node);
838 if (isFilteredOut && node === this._hoveredNode) 838 if (isFilteredOut && node === this._hoveredNode)
839 this._setHoveredNode(null); 839 this._setHoveredNode(null);
840 840
841 if (!isFilteredOut) 841 if (!isFilteredOut)
842 nodesToRefresh.push(node); 842 nodesToRefresh.push(node);
843 var request = node.request(); 843 var request = node.request();
844 this._timeCalculator.updateBoundaries(request); 844 this._timeCalculator.updateBoundaries(request);
845 this._durationCalculator.updateBoundaries(request); 845 this._durationCalculator.updateBoundaries(request);
846 if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut) 846 var newParent = this._parentNodeForInsert(node);
847 if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut && node.parent === newParent)
847 continue; 848 continue;
848 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut; 849 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
849 var newParent = this._parentNodeForInsert(node);
850 var removeFromParent = node.parent && (isFilteredOut || node.parent !== ne wParent); 850 var removeFromParent = node.parent && (isFilteredOut || node.parent !== ne wParent);
851 if (removeFromParent) { 851 if (removeFromParent) {
852 var parent = node.parent; 852 var parent = node.parent;
853 parent.removeChild(node); 853 parent.removeChild(node);
854 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) { 854 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) {
855 var grandparent = parent.parent; 855 var grandparent = parent.parent;
856 grandparent.removeChild(parent); 856 grandparent.removeChild(parent);
857 parent = grandparent; 857 parent = grandparent;
858 } 858 }
859 } 859 }
(...skipping 977 matching lines...) Expand 10 before | Expand all | Expand 10 after
1837 * @return {?*} 1837 * @return {?*}
1838 */ 1838 */
1839 groupForRequest: function(request) {}, 1839 groupForRequest: function(request) {},
1840 1840
1841 /** 1841 /**
1842 * @param {!*} key 1842 * @param {!*} key
1843 * @return {string} 1843 * @return {string}
1844 */ 1844 */
1845 groupName: function(key) {} 1845 groupName: function(key) {}
1846 }; 1846 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698