Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2856853003: Enable mocking of RenderThreadImpl::blink_platform_impl (Closed)

Created:
3 years, 7 months ago by olegmax
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable mocking of RenderThreadImpl::blink_platform_impl RenderFrameImpl::EnsureMojoBuiltinsAreAvailable() calls RenderThreadImpl::current() which is unavailable in RenderViewTests. New mockable RenderThreadImpl::current_blink_platform_impl() is to replace calls to RenderThreadImpl::current()->blink_platform_impl(). RenderViewTest sets its instance of RendererBlinkPlatformImplTestOverride as current_blink_platform_impl() for the lifetime of the test. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2856853003 Cr-Commit-Position: refs/heads/master@{#473125} Committed: https://chromium.googlesource.com/chromium/src/+/045f7fb1ba683e4635552c305fcc4c91b55e9411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M content/public/test/render_view_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
olegmax
3 years, 7 months ago (2017-05-03 10:13:40 UTC) #3
jam
Can you provide more background on what kind of tests you're trying to write? RenderViewTests ...
3 years, 7 months ago (2017-05-03 15:57:56 UTC) #4
olegmax
On 2017/05/03 15:57:56, jam wrote: > Can you provide more background on what kind of ...
3 years, 7 months ago (2017-05-03 16:14:00 UTC) #5
jam
On 2017/05/03 16:14:00, olegmax wrote: > On 2017/05/03 15:57:56, jam wrote: > > Can you ...
3 years, 7 months ago (2017-05-03 20:45:04 UTC) #6
sky
You added both John and myself. As John is doing the reviewing you don't need ...
3 years, 7 months ago (2017-05-04 03:00:31 UTC) #8
olegmax
On 2017/05/03 20:45:04, jam wrote: > On 2017/05/03 16:14:00, olegmax wrote: > > I'm trying ...
3 years, 7 months ago (2017-05-17 06:16:43 UTC) #9
jam
ok, lgtm
3 years, 7 months ago (2017-05-18 14:22:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856853003/1
3 years, 7 months ago (2017-05-18 14:27:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/297207)
3 years, 7 months ago (2017-05-18 15:13:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856853003/1
3 years, 7 months ago (2017-05-19 06:22:01 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 07:59:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/045f7fb1ba683e4635552c305fcc...

Powered by Google App Engine
This is Rietveld 408576698