Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h

Issue 2856783002: Autoplay time metric (Closed)
Patch Set: comments addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
diff --git a/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h b/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
index 55b5e1302270e1210168348b7bef0889598cea2a..4cc8c797333bd60db1e0ccf5893c070b72ad2d14 100644
--- a/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
+++ b/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
@@ -113,7 +113,7 @@ class CORE_EXPORT AutoplayUmaHelper : public EventListener,
// The autoplay sources.
std::set<AutoplaySource> sources_;
- // The media element this UMA helper is attached to. |m_element| owns |this|.
+ // The media element this UMA helper is attached to. |element| owns |this|.
Member<HTMLMediaElement> element_;
// The observer is used to observe whether a muted video autoplaying by play()
@@ -125,7 +125,7 @@ class CORE_EXPORT AutoplayUmaHelper : public EventListener,
// -----------------------------------------------------------------------
// Variables used for recording the duration of autoplay muted video playing
// offscreen. The variables are valid when
- // |m_autoplayOffscrenVisibilityObserver| is non-null.
+ // |autoplayOffscrenVisibilityObserver| is non-null.
// The recording stops whenever the playback pauses or the page is unloaded.
// The starting time of autoplaying muted video.
@@ -144,6 +144,8 @@ class CORE_EXPORT AutoplayUmaHelper : public EventListener,
// for recording as long as this observer is non-null.
Member<ElementVisibilityObserver>
muted_video_offscreen_duration_visibility_observer_;
+
+ double created_time_ms_;
Zhiqiang Zhang (Slow) 2017/05/02 00:12:05 nit: maybe "creation_time_ms_" is better?
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698