Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

Issue 2856753002: Linux native notifications: Add server capabilities metrics (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
index ee7b6c878fad53d1de093e16a22ecffbe38ea025..d3e8fa0a4698825560524d681616f25d39ec865c 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/notifications/notification_platform_bridge_linux.h"
#include <memory>
+#include <vector>
#include "base/callback.h"
#include "base/logging.h"
@@ -28,6 +29,15 @@ ACTION_P(RegisterSignalCallback, callback_addr) {
arg3.Run("" /* interface_name */, "" /* signal_name */, true /* success */);
}
+ACTION_P(OnGetCapabilities, capabilities) {
+ // MockObjectProxy::CallMethodAndBlock will wrap the return value in
+ // a unique_ptr.
+ dbus::Response* response = dbus::Response::CreateEmpty().release();
+ dbus::MessageWriter writer(response);
+ writer.AppendArrayOfStrings(capabilities);
+ return response;
+}
+
} // namespace
class NotificationPlatformBridgeLinuxTest : public testing::Test {
@@ -47,6 +57,10 @@ class NotificationPlatformBridgeLinuxTest : public testing::Test {
.WillOnce(testing::Return(mock_notification_proxy_.get()));
EXPECT_CALL(*mock_notification_proxy_.get(),
+ MockCallMethodAndBlock(testing::_, testing::_))
+ .WillOnce(OnGetCapabilities(std::vector<std::string>()));
+
+ EXPECT_CALL(*mock_notification_proxy_.get(),
ConnectToSignal(kFreedesktopNotificationsName, "ActionInvoked",
testing::_, testing::_))
.WillOnce(RegisterSignalCallback(&action_invoked_callback_));
« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_linux.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698