Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: Source/modules/geolocation/PositionOptions.h

Issue 285673002: Change value type of timeout and maximumAge in PositionOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8GeolocationCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/PositionOptions.h
diff --git a/Source/modules/geolocation/PositionOptions.h b/Source/modules/geolocation/PositionOptions.h
index 272270b81a89148703f5ceb1cc08729340224a8d..6885ff8c12d3931e981dcab61529754ffb8e6df9 100644
--- a/Source/modules/geolocation/PositionOptions.h
+++ b/Source/modules/geolocation/PositionOptions.h
@@ -39,27 +39,25 @@ public:
bool enableHighAccuracy() const { return m_highAccuracy; }
void setEnableHighAccuracy(bool enable) { m_highAccuracy = enable; }
bool hasTimeout() const { return m_hasTimeout; }
- int timeout() const
+ unsigned timeout() const
{
ASSERT(hasTimeout());
return m_timeout;
}
- void setTimeout(int timeout)
+ void setTimeout(unsigned timeout)
{
- ASSERT(timeout >= 0);
m_hasTimeout = true;
m_timeout = timeout;
}
bool hasMaximumAge() const { return m_hasMaximumAge; }
- int maximumAge() const
+ unsigned maximumAge() const
{
ASSERT(hasMaximumAge());
return m_maximumAge;
}
void clearMaximumAge() { m_hasMaximumAge = false; }
- void setMaximumAge(int age)
+ void setMaximumAge(unsigned age)
{
- ASSERT(age >= 0);
m_hasMaximumAge = true;
m_maximumAge = age;
}
@@ -74,9 +72,9 @@ private:
bool m_highAccuracy;
bool m_hasTimeout;
- int m_timeout;
+ unsigned m_timeout;
bool m_hasMaximumAge;
- int m_maximumAge;
+ unsigned m_maximumAge;
};
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8GeolocationCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698