Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/modules/geolocation/PositionOptions.h

Issue 285673002: Change value type of timeout and maximumAge in PositionOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/PositionOptions.h
diff --git a/Source/modules/geolocation/PositionOptions.h b/Source/modules/geolocation/PositionOptions.h
index 272270b81a89148703f5ceb1cc08729340224a8d..8b6e8caca1a47f28967ba7839d2b09a471c66652 100644
--- a/Source/modules/geolocation/PositionOptions.h
+++ b/Source/modules/geolocation/PositionOptions.h
@@ -39,25 +39,25 @@ public:
bool enableHighAccuracy() const { return m_highAccuracy; }
void setEnableHighAccuracy(bool enable) { m_highAccuracy = enable; }
bool hasTimeout() const { return m_hasTimeout; }
- int timeout() const
+ unsigned timeout() const
{
ASSERT(hasTimeout());
return m_timeout;
}
- void setTimeout(int timeout)
+ void setTimeout(unsigned timeout)
{
ASSERT(timeout >= 0);
Michael van Ouwerkerk 2014/05/13 16:15:17 Would this assert ever trigger on an unsigned int?
kihong 2014/05/14 03:44:25 Done.
m_hasTimeout = true;
m_timeout = timeout;
}
bool hasMaximumAge() const { return m_hasMaximumAge; }
- int maximumAge() const
+ unsigned maximumAge() const
{
ASSERT(hasMaximumAge());
return m_maximumAge;
}
void clearMaximumAge() { m_hasMaximumAge = false; }
- void setMaximumAge(int age)
+ void setMaximumAge(unsigned age)
{
ASSERT(age >= 0);
Michael van Ouwerkerk 2014/05/13 16:15:17 Same here.
kihong 2014/05/14 03:44:25 Done.
m_hasMaximumAge = true;
@@ -74,9 +74,9 @@ private:
bool m_highAccuracy;
bool m_hasTimeout;
- int m_timeout;
+ unsigned m_timeout;
bool m_hasMaximumAge;
- int m_maximumAge;
+ unsigned m_maximumAge;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698