Change value type of timeout and maximumAge in PositionOptions

Source/bindings/v8/custom/V8GeolocationCustom.cpp

 /*
  * Copyright 2009, The Android Open Source Project
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 67 matching lines @@
     }
     if (!timeoutValue->IsUndefined()) {
         v8::Local<v8::Number> timeoutNumber = timeoutValue->ToNumber();
         if (timeoutNumber.IsEmpty()) {
             succeeded = false;
             return nullptr;
         }
         double timeoutDouble = timeoutNumber->Value();
         // If the value is positive infinity, there's nothing to do.
         if (!(std::isinf(timeoutDouble) && timeoutDouble > 0)) {
-            v8::Local<v8::Int32> timeoutInt32 = timeoutValue->ToInt32();
-            if (timeoutInt32.IsEmpty()) {
+            v8::Local<v8::Uint32> timeoutUint32 = timeoutValue->ToUint32();
+            if (timeoutUint32.IsEmpty()) {
                 succeeded = false;
                 return nullptr;
             }
             // Wrap to int32 and force non-negative to match behavior of window.setTimeout.

[Michael van Ouwerkerk, 2014/05/13 16:15:17]

Update this comment.

[kihong, 2014/05/14 03:44:25]

Done.

-            options->setTimeout(max(0, timeoutInt32->Value()));
+            options->setTimeout(std::max<unsigned>(0, timeoutUint32->Value()));

[Michael van Ouwerkerk, 2014/05/13 16:15:17]

The specification specifies [Clamp] so that overflow does not become 0, but max
value. Is that correctly implemented here? Is there a test for it?

See
http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-Clamp-...

         }
     }
 
     v8::Local<v8::Value> maximumAgeValue = object->Get(v8AtomicString(isolate, "maximumAge"));
     if (maximumAgeValue.IsEmpty()) {
         succeeded = false;
         return nullptr;
     }
     if (!maximumAgeValue->IsUndefined()) {
         v8::Local<v8::Number> maximumAgeNumber = maximumAgeValue->ToNumber();
         if (maximumAgeNumber.IsEmpty()) {
             succeeded = false;
             return nullptr;
         }
         double maximumAgeDouble = maximumAgeNumber->Value();
         if (std::isinf(maximumAgeDouble) && maximumAgeDouble > 0) {
             // If the value is positive infinity, clear maximumAge.
             options->clearMaximumAge();
         } else {
-            v8::Local<v8::Int32> maximumAgeInt32 = maximumAgeValue->ToInt32();
-            if (maximumAgeInt32.IsEmpty()) {
+            v8::Local<v8::Uint32> maximumAgeUint32 = maximumAgeValue->ToUint32();
+            if (maximumAgeUint32.IsEmpty()) {
                 succeeded = false;
                 return nullptr;
             }
             // Wrap to int32 and force non-negative to match behavior of window.setTimeout.

[Michael van Ouwerkerk, 2014/05/13 16:15:17]

Update comment.

[kihong, 2014/05/14 03:44:25]

Done.

-            options->setMaximumAge(max(0, maximumAgeInt32->Value()));
+            options->setMaximumAge(std::max<unsigned>(0, maximumAgeUint32->Value()));
         }
     }
 
     return options.release();
 }
 
 void V8Geolocation::getCurrentPositionMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     bool succeeded = false;
 
@@ skipping 38 matching lines @@
     if (!succeeded)
         return;
     ASSERT(positionOptions);
 
     Geolocation* geolocation = V8Geolocation::toNative(info.Holder());
     int watchId = geolocation->watchPosition(positionCallback.release(), positionErrorCallback.release(), positionOptions.release());
     v8SetReturnValue(info, watchId);
 }
 
 } // namespace WebCore