Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2856713002: List all failing tests in compile/outline.status files. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

List all failing tests in compile/outline.status files. When I marked them as passing in the other CL, they were still passing even though I had not generated corresponding expectation files. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e0ac0ad0f6408573f6329cfbb1db62578f67a470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -18 lines) Patch
M pkg/front_end/test/fasta/compile.status View 1 chunk +287 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +287 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-01 21:05:52 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-01 21:06:36 UTC) #2
scheglov
3 years, 7 months ago (2017-05-01 21:07:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0ac0ad0f6408573f6329cfbb1db62578f67a470 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698