components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc - Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID. (Closed)

Patch Set: Simplify ExtNavThrottle Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc ('k') | content/browser/frame_host/navigation_handle_impl.h » ('j') | extensions/browser/extension_navigation_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

index 32b679cf7c333a3fdf17b7100dbe00feb3ea5ba8..1d4161870d7d4e0d65ab092ee9f1fa37dc2349db 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc

@@ -248,8 +248,7 @@ AsyncDocumentSubresourceFilter*

ContentSubresourceFilterThrottleManager::GetParentFrameFilter(

content::NavigationHandle* child_frame_navigation) {

DCHECK(!child_frame_navigation->IsInMainFrame());

- content::RenderFrameHost* parent = web_contents()->FindFrameByFrameTreeNodeId(

- child_frame_navigation->GetParentFrameTreeNodeId());

+ content::RenderFrameHost* parent = child_frame_navigation->GetParentFrame();

DCHECK(parent);

auto it = activated_frame_hosts_.find(parent);

return it == activated_frame_hosts_.end() ? nullptr : it->second.get();