extensions/browser/extension_api_frame_id_map.cc - Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_api_frame_id_map.cc

Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_api_frame_id_map.cc

diff --git a/extensions/browser/extension_api_frame_id_map.cc b/extensions/browser/extension_api_frame_id_map.cc

index bd0e19c8625cf687358a7c6ec2b8e4fce5880161..86fdd4c9d7356e9539fe85dd8f638af5aaba9172 100644

--- a/extensions/browser/extension_api_frame_id_map.cc

+++ b/extensions/browser/extension_api_frame_id_map.cc

@@ -148,7 +148,7 @@ content::RenderFrameHost* ExtensionApiFrameIdMap::GetRenderFrameHostById(

return web_contents->GetMainFrame();

DCHECK_GE(frame_id, 1);

- return web_contents->FindFrameByFrameTreeNodeId(frame_id);

+ return web_contents->UnsafeFindFrameByFrameTreeNodeId(frame_id);

}

ExtensionApiFrameIdMap::FrameData ExtensionApiFrameIdMap::KeyToValue(