components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc - Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc

Issue 2856653004: Require a process ID when looking up RFHs by FrameTreeNode ID. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc

diff --git a/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc b/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc

index dfa6be5a8bd744d712f56147909d523b7d780494..0e755245c872288e89c058fef4010c9bb05cf36e 100644

--- a/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc

+++ b/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc

@@ -82,9 +82,7 @@ ActivationStateComputingNavigationThrottle::WillProcessResponse() {

params.document_url = navigation_handle()->GetURL();

params.parent_activation_state = parent_activation_state_.value();

if (!navigation_handle()->IsInMainFrame()) {

- content::RenderFrameHost* parent =

- navigation_handle()->GetWebContents()->FindFrameByFrameTreeNodeId(

- navigation_handle()->GetParentFrameTreeNodeId());

+ content::RenderFrameHost* parent = navigation_handle()->GetParentFrame();

DCHECK(parent);

params.parent_document_origin = parent->GetLastCommittedOrigin();

}