Require a process ID when looking up RFHs by FrameTreeNode ID.

content/public/browser/navigation_handle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 65 matching lines @@
   //  * using window.history.pushState
   virtual bool IsRendererInitiated() = 0;
 
   // Returns the FrameTreeNode ID for the frame in which the navigation is
   // performed. This ID is browser-global and uniquely identifies a frame that
   // hosts content. The identifier is fixed at the creation of the frame and
   // stays constant for the lifetime of the frame.
   virtual int GetFrameTreeNodeId() = 0;
 
   // Returns the FrameTreeNode ID for the parent frame. If this navigation is
   // taking place in the main frame, the value returned is -1.

[ncarter (slow), 2017/05/01 22:15:32]

Deprecate this?

[Charlie Reis, 2017/05/01 22:36:51]

Interesting.  Yes, the only other caller is
ExtensionApiFrameIdMap::GetParentFrameId, and that could just call
GetFrameTreeNodeId on GetParentFrame.

Done.

   virtual int GetParentFrameTreeNodeId() = 0;
 
+  // Returns the RenderFrameHost for the parent frame, or nullptr if this
+  // navigation is taking place in the main frame. This value will not change
+  // during a navigation.
+  virtual RenderFrameHost* GetParentFrame() = 0;
+
   // The WebContents the navigation is taking place in.
   WebContents* GetWebContents();
 
   // The time the navigation started, recorded either in the renderer or in the
   // browser process. Corresponds to Navigation Timing API.
   virtual const base::TimeTicks& NavigationStart() = 0;
 
   // Whether or not the navigation was started within a context menu.
   virtual bool WasStartedFromContextMenu() const = 0;
 
@@ skipping 196 matching lines @@
 
   // The NavigationData that the embedder returned from
   // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
   // be a clone of the NavigationData.
   virtual NavigationData* GetNavigationData() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_