Roll Lighthouse & add error reporting

third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js

 /**
  * Copyright 2017 Google Inc. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
  *     http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
 'use strict';
 
+/* globals self */
+
 class DetailsRenderer {
   /**
    * @param {!DOM} dom
    */
   constructor(dom) {
+    /** @private {!DOM} */
     this._dom = dom;
   }
 
   /**
-   * @param {(!DetailsRenderer.DetailsJSON|!DetailsRenderer.CardsDetailsJSON)} details
+   * @param {!DetailsRenderer.DetailsJSON} details
    * @return {!Element}
    */
   render(details) {
     switch (details.type) {
       case 'text':
         return this._renderText(details);
-      case 'block':
-        return this._renderBlock(details);
       case 'cards':
         return this._renderCards(/** @type {!DetailsRenderer.CardsDetailsJSON} */ (details));
       case 'list':
-        return this._renderList(details);
+        return this._renderList(/** @type {!DetailsRenderer.ListDetailsJSON} */ (details));
       default:
         throw new Error(`Unknown type: ${details.type}`);
     }
   }
 
   /**
    * @param {!DetailsRenderer.DetailsJSON} text
    * @return {!Element}
    */
   _renderText(text) {
     const element = this._dom.createElement('div', 'lh-text');
     element.textContent = text.text;
     return element;
   }
 
   /**
-   * @param {!DetailsRenderer.DetailsJSON} block
-   * @return {!Element}
-   */
-  _renderBlock(block) {
-    const element = this._dom.createElement('div', 'lh-block');
-    const items = block.items || [];
-    for (const item of items) {
-      element.appendChild(this.render(item));
-    }
-    return element;
-  }
-
-  /**
-   * @param {!DetailsRenderer.DetailsJSON} list
+   * @param {!DetailsRenderer.ListDetailsJSON} list
    * @return {!Element}
    */
   _renderList(list) {
     const element = this._dom.createElement('details', 'lh-details');
     if (list.header) {
       const summary = this._dom.createElement('summary', 'lh-list__header');
       summary.textContent = list.header.text;
       element.appendChild(summary);
     }
 
     const itemsElem = this._dom.createElement('div', 'lh-list__items');
-    const items = list.items || [];
-    for (const item of items) {
+    for (const item of list.items) {
       itemsElem.appendChild(this.render(item));
     }
     element.appendChild(itemsElem);
     return element;
   }
 
   /**
    * @param {!DetailsRenderer.CardsDetailsJSON} details
    * @return {!Element}
    */
@@ skipping 19 matching lines @@
       }
     }
 
     element.appendChild(cardsParent);
     return element;
   }
 }
 
 if (typeof module !== 'undefined' && module.exports) {
   module.exports = DetailsRenderer;
+} else {
+  self.DetailsRenderer = DetailsRenderer;
 }
 
 /**
  * @typedef {{
  *     type: string,
- *     text: (string|undefined),
- *     header: (!DetailsRenderer.DetailsJSON|undefined),
- *     items: (!Array<!DetailsRenderer.DetailsJSON>|undefined)
+ *     text: (string|undefined)
  * }}
  */
 DetailsRenderer.DetailsJSON; // eslint-disable-line no-unused-expressions
 
+/**
+ * @typedef {{
+ *     type: string,
+ *     header: ({text: string}|undefined),
+ *     items: !Array<{type: string, text: (string|undefined)}>
+ * }}
+ */
+DetailsRenderer.ListDetailsJSON; // eslint-disable-line no-unused-expressions
+
 /** @typedef {{
  *     type: string,
- *     text: string,
- *     header: !DetailsRenderer.DetailsJSON,
+ *     header: ({text: string}|undefined),
  *     items: !Array<{title: string, value: string, snippet: (string|undefined), target: string}>
  * }}
  */
 DetailsRenderer.CardsDetailsJSON; // eslint-disable-line no-unused-expressions