Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2856643002: Explicitly represent "no surface ID yet" in WMPI. (Closed)
Patch Set: removed redundant check Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index af8d74c1a027f7a5f14a07eb8dc33f0d41529a15..92c520df3f605040b6fb788a60b90c3dc98dd04c 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -341,6 +341,7 @@ bool WebMediaPlayerImpl::SupportsOverlayFullscreenVideo() {
void WebMediaPlayerImpl::EnableOverlay() {
overlay_enabled_ = true;
if (surface_manager_) {
+ overlay_surface_id_.reset();
surface_created_cb_.Reset(
base::Bind(&WebMediaPlayerImpl::OnSurfaceCreated, AsWeakPtr()));
surface_manager_->CreateFullscreenSurface(pipeline_metadata_.natural_size,
@@ -359,7 +360,7 @@ void WebMediaPlayerImpl::DisableOverlay() {
if (decoder_requires_restart_for_overlay_)
ScheduleRestart();
else if (!set_surface_cb_.is_null())
- set_surface_cb_.Run(overlay_surface_id_);
+ set_surface_cb_.Run(*overlay_surface_id_);
}
void WebMediaPlayerImpl::EnteredFullscreen() {
@@ -1708,10 +1709,10 @@ void WebMediaPlayerImpl::OnSurfaceRequested(
// If we're waiting for the surface to arrive, OnSurfaceCreated() will be
// called later when it arrives; so do nothing for now.
- if (overlay_enabled_ && overlay_surface_id_ == SurfaceManager::kNoSurfaceID)
+ if (!overlay_surface_id_)
return;
- OnSurfaceCreated(overlay_surface_id_);
+ OnSurfaceCreated(*overlay_surface_id_);
}
std::unique_ptr<Renderer> WebMediaPlayerImpl::CreateRenderer() {
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698