Use off-heap data for class check instructions

runtime/vm/intrinsifier.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Class for intrinsifying functions.
 
 #include "vm/assembler.h"
 #include "vm/compiler.h"
 #include "vm/cpu.h"
 #include "vm/flags.h"
 #include "vm/flow_graph.h"
@@ skipping 514 matching lines @@
           rep = kUnboxedInt32x4;
           break;
         case kTypedDataFloat64x2ArrayCid:
           value_check_cid = kFloat64x2Cid;
           rep = kUnboxedFloat64x2;
           break;
         default:
           // Float32/Float64 case already handled.
           break;
       }
-      const ICData& value_check = ICData::ZoneHandle(
-          ICData::New(flow_graph->function(),
-                      Symbols::Empty(),       // Dummy function name.
-                      Object::empty_array(),  // Dummy args. descr.
-                      Thread::kNoDeoptId, 1, false));
-      value_check.AddReceiverCheck(value_check_cid, flow_graph->function());
+      Zone* zone = flow_graph->zone();
+      Cids* value_check = new (zone) Cids(zone);
+      value_check->Add(new (zone) CidRange(value_check_cid, value_check_cid));

[Vyacheslav Egorov (Google), 2017/05/09 21:07:28]

can this be Cids::CreateMonomorphic?

[erikcorry, 2017/05/10 08:47:43]

Done.

       builder.AddInstruction(
-          new CheckClassInstr(new Value(value), Thread::kNoDeoptId, value_check,
-                              builder.TokenPos()));
+          new CheckClassInstr(new Value(value), Thread::kNoDeoptId,
+                              *value_check, builder.TokenPos()));
       value = builder.AddUnboxInstr(rep, new Value(value),
                                     /* is_checked = */ true);
       if (array_cid == kTypedDataFloat32ArrayCid) {
         value = builder.AddDefinition(
             new DoubleToFloatInstr(new Value(value), Thread::kNoDeoptId));
       }
       break;
     }
     default:
       UNREACHABLE();
@@ skipping 169 matching lines @@
 
 bool Intrinsifier::Build_ExternalTwoByteStringCodeUnitAt(
     FlowGraph* flow_graph) {
   return BuildCodeUnitAt(flow_graph, kExternalTwoByteStringCid);
 }
 
 
 static bool BuildBinaryFloat32x4Op(FlowGraph* flow_graph, Token::Kind kind) {
   if (!FlowGraphCompiler::SupportsUnboxedSimd128()) return false;
 
+  Zone* zone = flow_graph->zone();
   GraphEntryInstr* graph_entry = flow_graph->graph_entry();
   TargetEntryInstr* normal_entry = graph_entry->normal_entry();
   BlockBuilder builder(flow_graph, normal_entry);
 
   Definition* right = builder.AddParameter(1);
   Definition* left = builder.AddParameter(2);
 
-  const ICData& value_check = ICData::ZoneHandle(ICData::New(
-      flow_graph->function(), String::Handle(flow_graph->function().name()),
-      Object::empty_array(),  // Dummy args. descr.
-      Thread::kNoDeoptId, 1, false));
-  value_check.AddReceiverCheck(kFloat32x4Cid, flow_graph->function());
+  Cids* value_check = new (zone) Cids(zone);
+  value_check->Add(new (zone) CidRange(kFloat32x4Cid, kFloat32x4Cid));

[Vyacheslav Egorov (Google), 2017/05/09 21:07:28]

can this be Cids::CreateMonomorphic()?

[erikcorry, 2017/05/10 08:47:43]

Done.

   // Check argument. Receiver (left) is known to be a Float32x4.
   builder.AddInstruction(new CheckClassInstr(
-      new Value(right), Thread::kNoDeoptId, value_check, builder.TokenPos()));
+      new Value(right), Thread::kNoDeoptId, *value_check, builder.TokenPos()));
   Definition* left_simd =
       builder.AddUnboxInstr(kUnboxedFloat32x4, new Value(left),
                             /* is_checked = */ true);
 
   Definition* right_simd =
       builder.AddUnboxInstr(kUnboxedFloat32x4, new Value(right),
                             /* is_checked = */ true);
 
   Definition* unboxed_result = builder.AddDefinition(new BinaryFloat32x4OpInstr(
       kind, new Value(left_simd), new Value(right_simd), Thread::kNoDeoptId));
@@ skipping 181 matching lines @@
 }
 
 
 bool Intrinsifier::Build_GrowableArraySetData(FlowGraph* flow_graph) {
   GraphEntryInstr* graph_entry = flow_graph->graph_entry();
   TargetEntryInstr* normal_entry = graph_entry->normal_entry();
   BlockBuilder builder(flow_graph, normal_entry);
 
   Definition* data = builder.AddParameter(1);
   Definition* growable_array = builder.AddParameter(2);
+  Zone* zone = flow_graph->zone();
 
-  const ICData& value_check = ICData::ZoneHandle(ICData::New(
-      flow_graph->function(), String::Handle(flow_graph->function().name()),
-      Object::empty_array(),  // Dummy args. descr.
-      Thread::kNoDeoptId, 1, false));
-  value_check.AddReceiverCheck(kArrayCid, flow_graph->function());
+  Cids* value_check = Cids::CreateMonomorphic(zone, kArrayCid);
   builder.AddInstruction(new CheckClassInstr(
-      new Value(data), Thread::kNoDeoptId, value_check, builder.TokenPos()));
+      new Value(data), Thread::kNoDeoptId, *value_check, builder.TokenPos()));
 
   builder.AddInstruction(new StoreInstanceFieldInstr(
       GrowableObjectArray::data_offset(), new Value(growable_array),
       new Value(data), kEmitStoreBarrier, builder.TokenPos()));
   // Return null.
   Definition* null_def = builder.AddNullDefinition();
   builder.AddIntrinsicReturn(new Value(null_def));
   return true;
 }
 
@@ skipping 214 matching lines @@
 }
 
 
 void Intrinsifier::RegExp_ExecuteMatchSticky(Assembler* assembler) {
   IntrinsifyRegExpExecuteMatch(assembler, /*sticky=*/true);
 }
 #endif  // !defined(TARGET_ARCH_DBC)
 
 
 }  // namespace dart