Use off-heap data for class check instructions

runtime/vm/aot_optimizer.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_AOT_OPTIMIZER_H_
 #define RUNTIME_VM_AOT_OPTIMIZER_H_
 
 #include "vm/intermediate_language.h"
 #include "vm/flow_graph.h"
 
@@ skipping 35 matching lines @@
                     Instruction* instr,
                     Environment* env,
                     FlowGraph::UseKind use_kind) {
     flow_graph_->InsertBefore(next, instr, env, use_kind);
   }
 
  private:
   // Attempt to build ICData for call using propagated class-ids.
   bool TryCreateICData(InstanceCallInstr* call);
 
-  bool TryReplaceWithIndexedOp(InstanceCallInstr* call);
+  bool TryReplaceWithIndexedOp(InstanceCallInstr* call,
+                               const ICData* unary_checks);
 
   bool TryReplaceWithBinaryOp(InstanceCallInstr* call, Token::Kind op_kind);
   bool TryReplaceWithUnaryOp(InstanceCallInstr* call, Token::Kind op_kind);
 
   bool TryReplaceWithEqualityOp(InstanceCallInstr* call, Token::Kind op_kind);
   bool TryReplaceWithRelationalOp(InstanceCallInstr* call, Token::Kind op_kind);
 
   bool TryInlineFieldAccess(InstanceCallInstr* call);
   bool TryInlineInstanceGetter(InstanceCallInstr* call);
   bool TryInlineInstanceSetter(InstanceCallInstr* call,
                                const ICData& unary_ic_data);
 
   bool TryInlineInstanceMethod(InstanceCallInstr* call);
   void ReplaceWithInstanceOf(InstanceCallInstr* instr);
   bool TypeCheckAsClassEquality(const AbstractType& type);
   void ReplaceWithTypeCast(InstanceCallInstr* instr);
 
   bool TryReplaceInstanceCallWithInline(InstanceCallInstr* call);
 
   // Insert a check of 'to_check' determined by 'unary_checks'.  If the
   // check fails it will deoptimize to 'deopt_id' using the deoptimization
   // environment 'deopt_environment'.  The check is inserted immediately
   // before 'insert_before'.
   void AddCheckClass(Definition* to_check,
-                     const ICData& unary_checks,
+                     const Cids& cids,
                      intptr_t deopt_id,
                      Environment* deopt_environment,
                      Instruction* insert_before);
-  Instruction* GetCheckClass(Definition* to_check,
-                             const ICData& unary_checks,
-                             intptr_t deopt_id,
-                             TokenPosition token_pos);
 
   // Insert a Smi check if needed.
   void AddCheckSmi(Definition* to_check,
                    intptr_t deopt_id,
                    Environment* deopt_environment,
                    Instruction* insert_before);
 
-  // Add a class check for a call's first argument immediately before the
+  // Add a class check for a call's nth argument immediately before the
   // call, using the call's IC data to determine the check, and the call's
   // deopt ID and deoptimization environment if the check fails.
-  void AddReceiverCheck(InstanceCallInstr* call);
+  void AddChecksToArgNr(InstanceCallInstr* call,

[Vyacheslav Egorov (Google), 2017/05/09 21:07:27]

s/ToArgNr/ForArgNr/ ?

[erikcorry, 2017/05/10 08:47:43]

Done.

+                        Definition* instr,
+                        int argument_number);
+
+  // Convenience version of AddChecksToArgNr that works on the 0th argument
+  // (receiver).
+  void AddReceiverCheck(InstanceCallInstr* call) {
+    AddChecksToArgNr(call, call->ArgumentAt(0), /* arg_number = */ 0);
+  }
 
   void ReplaceCall(Definition* call, Definition* replacement);
 
   bool RecognizeRuntimeTypeGetter(InstanceCallInstr* call);
   bool TryReplaceWithHaveSameRuntimeType(InstanceCallInstr* call);
 
   bool InstanceCallNeedsClassCheck(InstanceCallInstr* call,
                                    RawFunction::Kind kind) const;
 
   bool InlineFloat32x4BinaryOp(InstanceCallInstr* call, Token::Kind op_kind);
@@ skipping 29 matching lines @@
 
   bool has_unique_no_such_method_;
 
   DISALLOW_COPY_AND_ASSIGN(AotOptimizer);
 };
 
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_AOT_OPTIMIZER_H_