Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: pkg/analyzer/lib/src/fasta/ast_builder.dart

Issue 2856463004: New tests and improvements for generics in comments parsing. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/analysis_server.iml ('k') | pkg/analyzer/test/generated/parser_fasta_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/fasta/ast_builder.dart
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
index a49b372d46c16ff4ff500f0306f104a228272a36..70a7539d3cd64b939cd03f22ad0543f247a48767 100644
--- a/pkg/analyzer/lib/src/fasta/ast_builder.dart
+++ b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -1938,6 +1938,11 @@ class AstBuilder extends ScopeListener {
return tokenToStartReplacing;
}
+ @override
+ void discardTypeReplacedWithCommentTypeAssign() {
Paul Berry 2017/05/01 18:24:42 Do we need to add a similar override to BodyBuilde
+ pop();
+ }
+
/// Check if the given [token] has a comment token with the given [info],
/// which should be either [TokenType.GENERIC_METHOD_TYPE_ASSIGN] or
/// [TokenType.GENERIC_METHOD_TYPE_LIST]. If found, parse the comment
« no previous file with comments | « pkg/analysis_server/analysis_server.iml ('k') | pkg/analyzer/test/generated/parser_fasta_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698