Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2856463004: New tests and improvements for generics in comments parsing. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

New tests and improvements for generics in comments parsing. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/37092ed677f9f3a42dbb65f6161dacceb5e9c0bd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -18 lines) Patch
M pkg/analysis_server/analysis_server.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +5 lines, -0 lines 1 comment Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +98 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 4 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-01 18:16:30 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2856463004/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart File pkg/analyzer/lib/src/fasta/ast_builder.dart (right): https://codereview.chromium.org/2856463004/diff/1/pkg/analyzer/lib/src/fasta/ast_builder.dart#newcode1942 pkg/analyzer/lib/src/fasta/ast_builder.dart:1942: void discardTypeReplacedWithCommentTypeAssign() { Do we need to add ...
3 years, 7 months ago (2017-05-01 18:24:43 UTC) #2
scheglov
3 years, 7 months ago (2017-05-01 19:52:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37092ed677f9f3a42dbb65f6161dacceb5e9c0bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698