Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 285643006: Kill WTF::DecimalNumber class (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, krit, blink-reviews-wtf_chromium.org, jamesr, blink-reviews-css, ed+blinkwatch_opera.com, Mikhail, jbroman, danakj, abarth-chromium, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., rwlbuis, yosin_UTC9, tkent
Visibility:
Public.

Description

Kill WTF::DecimalNumber class Kill WTF::DecimalNumber class and use the Decimal class from platform/ instead. There is little sense in having 2 different classes to do the same thing. This makes the code a bit more consistent and also reduces the release binary size by ~15Kb. R=eseidel@chromium.org, abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174260

Patch Set 1 #

Patch Set 2 : Fix unit test #

Patch Set 3 : Rebaseline more tests #

Patch Set 4 : clean up #

Patch Set 5 : Inline single-line function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -429 lines) Patch
M LayoutTests/animations/interpolation/webkit-column-width-interpolation.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/webkit-column-width-interpolation-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-transform-interpolation-expected.txt View 1 2 4 chunks +91 lines, -91 lines 0 comments Download
M LayoutTests/animations/interpolation/zoom-iterpolation.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/zoom-iterpolation-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/calc/simplification-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/filters/filter-property-computed-style-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/filters/script-tests/filter-property-computed-style.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/large-value-csstext-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/round-trip-values-expected.txt View 3 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/transforms/transform-inherit-initial-unprefixed.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/transforms/transform-inherit-initial-unprefixed-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 3 2 chunks +5 lines, -11 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 2 3 4 2 chunks +3 lines, -6 lines 0 comments Download
M Source/core/css/MediaQuerySetTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/JSONValues.cpp View 2 chunks +3 lines, -17 lines 0 comments Download
M Source/platform/graphics/Color.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
D Source/wtf/DecimalNumber.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/wtf/DecimalNumber.cpp View 1 chunk +0 lines, -196 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
I noticed that we have 2 classes to do the same thing: - wtf/DecimalNumber.h - ...
6 years, 7 months ago (2014-05-14 01:19:32 UTC) #1
tkent
lgtm. We haven't evaluated the performance of Decimal class. This might cause performance issues.
6 years, 7 months ago (2014-05-19 00:18:08 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-19 00:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/285643006/80001
6 years, 7 months ago (2014-05-19 00:18:36 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 10:08:04 UTC) #5
Message was sent while issue was closed.
Change committed as 174260

Powered by Google App Engine
This is Rietveld 408576698