Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2856423002: input: Change how synthesized events are dispatched in telemetry tests. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index ae875fcb6ef94a83829d86f8802e9ff0e3d91f30..ff8cc0cd25a83becb4398de2ad739bf874c04375 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -2086,15 +2086,16 @@ void RenderWidgetHostViewAndroid::OnBeginFrame(const cc::BeginFrameArgs& args) {
// Update |last_begin_frame_args_| before handling
// |outstanding_begin_frame_requests_| to prevent the BeginFrameSource from
// sending the same MISSED args in infinite recursion. This may otherwise
- // happen if |host_->FlushInput()| causes a synchronous OnSetNeedsFlushInput()
- // which can lead to |begin_frame_source_->AddObserver()| and OnBeginFrame().
- // By setting |last_begin_frame_args_|, we indicate to the source not to send
- // the same args during |AddObserver()| again.
+ // happen if |host_->OnBeginFrame()| causes a synchronous
+ // OnSetNeedsFlushInput() which can lead to
+ // |begin_frame_source_->AddObserver()| and OnBeginFrame(). By setting
+ // |last_begin_frame_args_|, we indicate to the source not to send the same
+ // args during |AddObserver()| again.
last_begin_frame_args_ = args;
if (outstanding_begin_frame_requests_ & FLUSH_INPUT) {
ClearBeginFrameRequest(FLUSH_INPUT);
- host_->FlushInput();
+ host_->OnBeginFrame();
}
if ((outstanding_begin_frame_requests_ & BEGIN_FRAME) ||

Powered by Google App Engine
This is Rietveld 408576698