Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: milo/appengine/buildbot/buildinfo_test.go

Issue 2856273004: Milo: Increase test coverage for appengine/buildbot (Closed)
Patch Set: GoFmt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbot/buildinfo_test.go
diff --git a/milo/appengine/buildbot/buildinfo_test.go b/milo/appengine/buildbot/buildinfo_test.go
index 10dfb484061b8a02e68999d5fae54f3641cc3f0b..fe8524cfd630b218fc5b6bdf88f12311c162bcae 100644
--- a/milo/appengine/buildbot/buildinfo_test.go
+++ b/milo/appengine/buildbot/buildinfo_test.go
@@ -134,6 +134,16 @@ func TestBuildInfo(t *testing.T) {
},
}
+ Convey("Load an invalid build", func() {
nodir 2017/05/18 03:17:15 invalid or nonexisting? if the latter, the respons
Ryan Tseng 2017/05/26 18:10:52 Done.
+ _, err := bip.GetBuildInfo(c,
+ &milo.BuildInfoRequest_BuildBot{
+ MasterName: "foo master",
+ BuilderName: "bar builder",
+ BuildNumber: 1334,
+ }, "")
+ So(err.Error(), ShouldResemble, "rpc error: code = Internal desc = ")
+ })
+
Convey("Can load a BuildBot build by log location.", func() {
build.Properties = append(build.Properties, []*buildbotProperty{
{Name: "log_location", Value: "logdog://example.com/testproject/foo/bar/+/baz/annotations"},

Powered by Google App Engine
This is Rietveld 408576698