Milo: Increase test coverage for appengine/buildbot

milo/appengine/buildbot/builder_test.go

Index: milo/appengine/buildbot/builder_test.go
diff --git a/milo/appengine/buildbot/builder_test.go b/milo/appengine/buildbot/builder_test.go
new file mode 100644
index 0000000000000000000000000000000000000000..414ce7f73d4874c419b6844f4832c6c4c6a0757e
--- /dev/null
+++ b/milo/appengine/buildbot/builder_test.go
@@ -0,0 +1,93 @@
+// Copyright 2017 The LUCI Authors. All rights reserved.
+// Use of this source code is governed under the Apache License, Version 2.0
+// that can be found in the LICENSE file.
+
+package buildbot
+
+import (
+	"context"
+	"testing"
+
+	"github.com/luci/gae/impl/memory"
+	"github.com/luci/gae/service/datastore"
+	"github.com/luci/luci-go/common/clock/testclock"
+
+	. "github.com/smartystreets/goconvey/convey"
+)
+
+func TestBuilder(t *testing.T) {
+	c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
+	c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
+	fakeTime := float64(123)
+	fakeResult := int(0)
+	fakeFailure := int(2)
+
+	// Seed a builder with 10 builds.
+	for i := 1; i < 10; i++ {
+		datastore.Put(c, &buildbotBuild{
+			Master:      "fake",
+			Buildername: "fake",
+			Number:      i,
+			Internal:    false,
+			Times:       []*float64{&fakeTime, &fakeTime},
+			Sourcestamp: &buildbotSourceStamp{},
+			Results:     &fakeResult,
+			Finished:    true,
+		})
+	}
+	// Failed build
+	datastore.Put(c, &buildbotBuild{
+		Master:      "fake",
+		Buildername: "fake",
+		Number:      10,
+		Internal:    false,
+		Times:       []*float64{&fakeTime, &fakeTime},
+		Sourcestamp: &buildbotSourceStamp{},
+		Results:     &fakeFailure,
+		Finished:    true,
+		Text:        []string{"failed", "stuff"},
+	})
+	putDSMasterJSON(c, &buildbotMaster{
+		Name:     "fake",
+		Builders: map[string]*buildbotBuilder{"fake": {}},
+	}, false)
+	datastore.GetTestable(c).Consistent(true)
+	datastore.GetTestable(c).AutoIndex(true)
+	datastore.GetTestable(c).CatchupIndexes()
+	Convey(`A test Environment`, t, func() {
+
+		Convey(`Invalid builder`, func() {
+			_, err := builderImpl(c, "fake", "not real builder", 2, "")
+			So(err.Error(), ShouldResemble, "Cannot find builder \"fake\" in master \"not real builder\".\nAvailable builders: \n\"fake\"")

[nodir, 2017/05/26 18:33:05]

should be `Cannot find builder "not real builder" in master "fake"...`

[Ryan Tseng, 2017/05/26 22:49:22]

Done.

+		})
+		Convey(`Basic 3 build builder`, func() {
+			Convey(`Fetch 2`, func() {
+				response, err := builderImpl(c, "fake", "fake", 2, "")
+				So(err, ShouldBeNil)
+				So(len(response.FinishedBuilds), ShouldEqual, 2)
+				So(response.NextCursor, ShouldNotEqual, "")
+				So(response.PrevCursor, ShouldEqual, "")
+				So(response.FinishedBuilds[0].Link.Label, ShouldEqual, "#10")
+				So(response.FinishedBuilds[0].Text, ShouldResemble, []string{"failed stuff"})
+				Convey(`Fetch another 2`, func() {
+					response2, err := builderImpl(c, "fake", "fake", 2, response.NextCursor)
+					So(err, ShouldBeNil)
+					So(len(response2.FinishedBuilds), ShouldEqual, 2)
+					So(response2.PrevCursor, ShouldEqual, "EMPTY")
+					Convey(`Fetch another 2`, func() {
+						response3, err := builderImpl(c, "fake", "fake", 2, response2.NextCursor)
+						So(err, ShouldBeNil)
+						So(len(response3.FinishedBuilds), ShouldEqual, 2)
+						So(response3.PrevCursor, ShouldNotEqual, "")
+						So(response3.PrevCursor, ShouldNotEqual, "EMPTY")
+						Convey(`Fetch the rest`, func() {
+							response4, err := builderImpl(c, "fake", "fake", 20, response3.NextCursor)
+							So(err, ShouldBeNil)
+							So(len(response4.FinishedBuilds), ShouldEqual, 4)
+						})
+					})
+				})
+			})
+		})
+	})
+}