Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Side by Side Diff: milo/appengine/buildbot/html.go

Issue 2856273004: Milo: Increase test coverage for appengine/buildbot (Closed)
Patch Set: GoFmt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The LUCI Authors. All rights reserved. 1 // Copyright 2015 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package buildbot 5 package buildbot
6 6
7 import ( 7 import (
8 "fmt" 8 "fmt"
9 "net/http" 9 "net/http"
10 "strconv" 10 "strconv"
(...skipping 20 matching lines...) Expand all
31 common.ErrorPage(c, http.StatusBadRequest, "No build number") 31 common.ErrorPage(c, http.StatusBadRequest, "No build number")
32 return 32 return
33 } 33 }
34 num, err := strconv.Atoi(buildNum) 34 num, err := strconv.Atoi(buildNum)
35 if err != nil { 35 if err != nil {
36 common.ErrorPage(c, http.StatusBadRequest, 36 common.ErrorPage(c, http.StatusBadRequest,
37 fmt.Sprintf("%s does not look like a number", buildNum)) 37 fmt.Sprintf("%s does not look like a number", buildNum))
38 return 38 return
39 } 39 }
40 40
41 » result, err := build(c.Context, master, builder, num) 41 » result, err := Build(c.Context, master, builder, num)
42 if err != nil { 42 if err != nil {
43 var code int 43 var code int
44 switch err { 44 switch err {
45 case errBuildNotFound: 45 case errBuildNotFound:
46 code = http.StatusNotFound 46 code = http.StatusNotFound
47 case errNotAuth: 47 case errNotAuth:
48 code = http.StatusUnauthorized 48 code = http.StatusUnauthorized
49 default: 49 default:
50 code = http.StatusInternalServerError 50 code = http.StatusInternalServerError
51 } 51 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 if err != nil { 86 if err != nil {
87 common.ErrorPage(c, http.StatusInternalServerError, err.Error()) 87 common.ErrorPage(c, http.StatusInternalServerError, err.Error())
88 return 88 return
89 } 89 }
90 90
91 // Render into the template 91 // Render into the template
92 templates.MustRender(c.Context, c.Writer, "pages/builder.html", template s.Args{ 92 templates.MustRender(c.Context, c.Writer, "pages/builder.html", template s.Args{
93 "Builder": result, 93 "Builder": result,
94 }) 94 })
95 } 95 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698