Milo: Increase test coverage for appengine/buildbot

milo/appengine/buildbot/build_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "flag"
         "fmt"
@@ skipping 31 matching lines @@
         actualBuild, err := json.MarshalIndent(actualContents, "", "  ")
         return ShouldEqual(string(actualBuild), string(refBuild))
 
 }
 
 func TestBuild(t *testing.T) {
         c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
         c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
 
         if *generate {
-                for _, tc := range testCases {
-                        fmt.Printf("Generating expectations for %s/%s\n", tc.builder, tc.build)
-                        build, err := build(c, "debug", tc.builder, tc.build)
+                for _, tc := range TestCases {

[nodir, 2017/05/18 03:17:15]

why test cases where made public?

[Ryan Tseng, 2017/05/26 18:10:51]

(Mentioned in the CL desc) html rendering tests have been moved into the
frontend module, but to share the test data, TestCases need to be public. 
TestCases is basically just a file listing of what is in the testdata folder.

+                        fmt.Printf("Generating expectations for %s/%s\n", tc.Builder, tc.Build)
+                        build, err := Build(c, "debug", tc.Builder, tc.Build)
                         if err != nil {
-                                panic(fmt.Errorf("Could not run build() for %s/%s: %s", tc.builder, tc.build, err))
+                                panic(fmt.Errorf("Could not run build() for %s/%s: %s", tc.Builder, tc.Build, err))
                         }
                         buildJSON, err := json.MarshalIndent(build, "", "  ")
                         if err != nil {
-                                panic(fmt.Errorf("Could not JSON marshal %s/%s: %s", tc.builder, tc.build, err))
+                                panic(fmt.Errorf("Could not JSON marshal %s/%s: %s", tc.Builder, tc.Build, err))
                         }
-                        fname := fmt.Sprintf("%s.%d.build.json", tc.builder, tc.build)
+                        fname := fmt.Sprintf("%s.%d.build.json", tc.Builder, tc.Build)
                         fpath := path.Join("expectations", fname)
                         err = ioutil.WriteFile(fpath, []byte(buildJSON), 0644)
                         if err != nil {
                                 panic(fmt.Errorf("Encountered error while trying to write to %s: %s", fpath, err))
                         }
                 }
                 return
         }
 
         Convey(`A test Environment`, t, func() {
                 c = testconfig.WithCommonClient(c, memcfg.New(bbAclConfigs))
                 c = auth.WithState(c, &authtest.FakeState{
                         Identity:       identity.AnonymousIdentity,
                         IdentityGroups: []string{"all"},
                 })
 
-                for _, tc := range testCases {
-                        Convey(fmt.Sprintf("Test Case: %s/%s", tc.builder, tc.build), func() {
-                                build, err := build(c, "debug", tc.builder, tc.build)
+                for _, tc := range TestCases {
+                        Convey(fmt.Sprintf("Test Case: %s/%s", tc.Builder, tc.Build), func() {
+                                build, err := Build(c, "debug", tc.Builder, tc.Build)
                                 So(err, ShouldBeNil)
-                                fname := fmt.Sprintf("%s.%d.build.json", tc.builder, tc.build)
+                                fname := fmt.Sprintf("%s.%d.build.json", tc.Builder, tc.Build)
                                 So(build, shouldMatchExpectationsFor, fname)
                         })
                 }
 
                 Convey(`Disallow anonomyous users from accessing internal builds`, func() {
                         ds.Put(c, &buildbotBuild{
                                 Master:      "fake",
                                 Buildername: "fake",
                                 Number:      1,
                                 Internal:    true,
@@ skipping 10 matching lines @@
         public_subscription: "projects/luci-milo/subscriptions/buildbot-public"
         internal_subscription: "projects/luci-milo/subscriptions/buildbot-private"
 }
 `
 
 var bbAclConfigs = map[string]memcfg.ConfigSet{
         "services/luci-milo": {
                 "settings.cfg": internalConfig,
         },
 }