Milo: Increase test coverage for appengine/buildbot

milo/appengine/frontend/buildbot_data.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
-package buildbot
+package frontend
 
 import (
         "fmt"
 
         "github.com/luci/gae/impl/memory"
         "github.com/luci/luci-go/common/clock/testclock"
         "github.com/luci/luci-go/milo/api/resp"
+        "github.com/luci/luci-go/milo/appengine/buildbot"
         "github.com/luci/luci-go/milo/appengine/common"
         "github.com/luci/luci-go/server/templates"
         "golang.org/x/net/context"
 )
 
-// We put this here because _test.go files are sometimes not built.
-var testCases = []struct {
-        builder string
-        build   int
-}{
-        {"CrWinGoma", 30608},
-        {"win_chromium_rel_ng", 246309},
-        {"newline", 1234},
-}
-
-// BuildTestData returns sample test data for build pages.
-func BuildTestData() []common.TestBundle {
+// buildbotBuildTestData returns sample test data for build pages.
+func buildbotBuildTestData() []common.TestBundle {
         c := memory.Use(context.Background())
         c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
         bundles := []common.TestBundle{}
-        for _, tc := range testCases {
-                build, err := build(c, "debug", tc.builder, tc.build)
+        for _, tc := range buildbot.TestCases {
+                build, err := buildbot.Build(c, "debug", tc.Builder, tc.Build)
                 if err != nil {
                         panic(fmt.Errorf(
                                 "Encountered error while building debug/%s/%s.\n%s",
-                                tc.builder, tc.build, err))
+                                tc.Builder, tc.Build, err))
                 }
                 bundles = append(bundles, common.TestBundle{
-                        Description: fmt.Sprintf("Debug page: %s/%d", tc.builder, tc.build),
+                        Description: fmt.Sprintf("Debug page: %s/%d", tc.Builder, tc.Build),
                         Data: templates.Args{
                                 "Build": build,
                         },
                 })
         }
         return bundles
 }
 
-// BiulderTestData returns sample test data for builder pages.
-func BuilderTestData() []common.TestBundle {
+// buildbotBuilderTestData returns sample test data for builder pages.
+func buildbotBuilderTestData() []common.TestBundle {
         return []common.TestBundle{
                 {
                         Description: "Basic Test no builds",
                         Data: templates.Args{
                                 "Builder": &resp.Builder{
                                         Name: "Sample Builder",
                                 },
                         },
                 },
                 {
@@ skipping 26 matching lines @@
                                                                 Label: "Some current build",
                                                         },
                                                         Revision: "deadbeef",
                                                 },
                                         },
                                 },
                         },
                 },
         }
 }