devil/devil/android/device_utils_test.py - Issue 2856253007: [devil] Revise how EnableRoot waits for the device to come back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: devil/devil/android/device_utils_test.py

Issue 2856253007: [devil] Revise how EnableRoot waits for the device to come back. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: devil/devil/android/device_utils_test.py

diff --git a/devil/devil/android/device_utils_test.py b/devil/devil/android/device_utils_test.py

index 53ac96b6855dc2009184ff6e612c373b45997a46..ebd3c62869711dc21506aa3a3ac80c5feebea3f7 100755

--- a/devil/devil/android/device_utils_test.py

+++ b/devil/devil/android/device_utils_test.py

@@ -316,7 +316,8 @@ class DeviceUtilsEnableRootTest(DeviceUtilsTest):

def testEnableRoot_succeeds(self):

with self.assertCalls(

self.call.adb.Root(),

- self.call.device.WaitUntilFullyBooted()):

+ self.call.adb.WaitForDevice(),

+ (self.call.device.GetProp('service.adb.root', cache=False), '1')):

self.device.EnableRoot()

def testEnableRoot_userBuild(self):