Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: media/gpu/android_video_surface_chooser.h

Issue 2856253004: removed AndroidOverlayFactory (Closed)
Patch Set: cl feedvback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_ 5 #ifndef MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_
6 #define MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_ 6 #define MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "media/base/android/android_overlay.h" 11 #include "media/base/android/android_overlay.h"
12 #include "media/base/android/android_overlay_factory.h"
13 #include "media/gpu/media_gpu_export.h" 12 #include "media/gpu/media_gpu_export.h"
14 13
15 namespace media { 14 namespace media {
16 15
17 // Manage details of which surface to use for video playback. 16 // Manage details of which surface to use for video playback.
18 class MEDIA_GPU_EXPORT AndroidVideoSurfaceChooser { 17 class MEDIA_GPU_EXPORT AndroidVideoSurfaceChooser {
19 public: 18 public:
20 // Notify the client that |overlay| is ready for use. The client may get 19 // Notify the client that |overlay| is ready for use. The client may get
21 // the surface immediately. 20 // the surface immediately.
22 using UseOverlayCB = 21 using UseOverlayCB =
23 base::Callback<void(std::unique_ptr<AndroidOverlay> overlay)>; 22 base::RepeatingCallback<void(std::unique_ptr<AndroidOverlay> overlay)>;
24 23
25 // Notify the client that the most recently provided overlay should be 24 // Notify the client that the most recently provided overlay should be
26 // discarded. The overlay is still valid, but we recommend against 25 // discarded. The overlay is still valid, but we recommend against
27 // using it soon, in favor of a SurfaceTexture. 26 // using it soon, in favor of a SurfaceTexture.
28 using UseSurfaceTextureCB = base::Callback<void(void)>; 27 using UseSurfaceTextureCB = base::RepeatingCallback<void(void)>;
29 28
30 // Callback that mirrors AndroidOverlay::DestroyedCB . The surface 29 // Callback that mirrors AndroidOverlay::DestroyedCB . The surface
31 // that was provided with |overlay| is being destroyed. 30 // that was provided with |overlay| is being destroyed.
32 using StopUsingOverlayImmediatelyCB = base::Callback<void(AndroidOverlay*)>; 31 using StopUsingOverlayImmediatelyCB =
32 base::RepeatingCallback<void(AndroidOverlay*)>;
33 33
34 AndroidVideoSurfaceChooser() {} 34 AndroidVideoSurfaceChooser() {}
35 virtual ~AndroidVideoSurfaceChooser() {} 35 virtual ~AndroidVideoSurfaceChooser() {}
36 36
37 // Notify us that our client is ready for overlays. We will send it a 37 // Notify us that our client is ready for overlays. We will send it a
38 // callback telling it whether to start with a SurfaceTexture or overlay, 38 // callback telling it whether to start with a SurfaceTexture or overlay,
39 // either synchronously or post one very soon. 39 // either synchronously or post one very soon. |initial_factory| can be
40 virtual void Initialize( 40 // an empty callback to indicate "no factory".
41 UseOverlayCB use_overlay_cb, 41 virtual void Initialize(UseOverlayCB use_overlay_cb,
42 UseSurfaceTextureCB use_surface_texture_cb, 42 UseSurfaceTextureCB use_surface_texture_cb,
43 StopUsingOverlayImmediatelyCB stop_immediately_cb, 43 StopUsingOverlayImmediatelyCB stop_immediately_cb,
44 std::unique_ptr<AndroidOverlayFactory> initial_factory) = 0; 44 AndroidOverlayFactoryCB initial_factory) = 0;
45 45
46 // Notify us that a new factory has arrived. May be null to indicate that 46 // Notify us that a new factory has arrived. May be is_null() to indicate
47 // the most recent factory has been revoked. 47 // that the most recent factory has been revoked.
48 virtual void ReplaceOverlayFactory( 48 virtual void ReplaceOverlayFactory(AndroidOverlayFactoryCB factory) = 0;
49 std::unique_ptr<AndroidOverlayFactory> factory) = 0;
50 49
51 private: 50 private:
52 DISALLOW_COPY_AND_ASSIGN(AndroidVideoSurfaceChooser); 51 DISALLOW_COPY_AND_ASSIGN(AndroidVideoSurfaceChooser);
53 }; 52 };
54 53
55 } // namespace media 54 } // namespace media
56 55
57 #endif // MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_ 56 #endif // MEDIA_GPU_ANDROID_VIDEO_SURFACE_CHOOSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698