media/base/android_overlay_mojo_factory.h - Issue 2856253004: removed AndroidOverlayFactory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/android_overlay_mojo_factory.h

Issue 2856253004: removed AndroidOverlayFactory (Closed)

Patch Set: cl feedvback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_BASE_ANDROID_OVERLAY_MOJO_FACTORY_CB_H_

	6 #define MEDIA_BASE_ANDROID_OVERLAY_MOJO_FACTORY_CB_H_

	7

	8 #include "base/callback.h"

	9 #include "base/macros.h"

	10 #include "media/base/android_overlay_config.h"

	11

	12 namespace media {

	13

	14 // Note that this compiles on non-android too.

	15 using AndroidOverlayMojoFactoryCB = base::RepeatingCallback<std::unique_ptr<

	16 AndroidOverlay>(base::UnguessableToken&, const AndroidOverlayConfig&)>
	xhwang 2017/06/01 05:50:59 ISTM this file lives in media/base and this callba ISTM this file lives in media/base and this callback has nothing to do with mojo. I wonder why we use "mojo" in the file/callback name? :) liberato (no reviews please) 2017/06/01 06:07:55 good point. the need for a base::UnguessableToken Show quoted text On 2017/06/01 05:50:59, xhwang wrote: > ISTM this file lives in media/base and this callback has nothing to do with > mojo. I wonder why we use "mojo" in the file/callback name? :) good point. the need for a base::UnguessableToken is specific to the mojo implementation of the AO api. it identifies the render frame that owns the overlay. that's the only connection. i'm not sure if it could be moved under media/mojo, or if there's a build rule that prevented it. i'll give it a try.
	17

	18 } // namespace media

	19

	20 #endif // MEDIA_BASE_ANDROID_OVERLAY_MOJO_FACTORY_CB_H_

OLD	NEW

« no previous file with comments | « media/base/android_overlay_config.cc ('k') | media/gpu/BUILD.gn » ('j') | no next file with comments »