Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: remoting/host/security_key/security_key_extension_session.cc

Issue 2856243002: [Chromoting] Add ProcessStatsDispatcher to send process stats to the client
Patch Set: Partially resolve the review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/constants.cc ('k') | remoting/protocol/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/security_key/security_key_extension_session.cc
diff --git a/remoting/host/security_key/security_key_extension_session.cc b/remoting/host/security_key/security_key_extension_session.cc
index f637981bbf44f013cb4326c9a9024cd4e8175fae..01146bb5e5eb6d7ab22fab1f0513e0eebb83b2f1 100644
--- a/remoting/host/security_key/security_key_extension_session.cc
+++ b/remoting/host/security_key/security_key_extension_session.cc
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/single_thread_task_runner.h"
#include "base/values.h"
+#include "remoting/base/constants.h"
#include "remoting/base/logging.h"
#include "remoting/host/client_session_details.h"
#include "remoting/host/security_key/security_key_auth_handler.h"
@@ -19,9 +20,6 @@
namespace {
-// Used as the type attribute of all Security Key protocol::ExtensionMessages.
-const char kExtensionMessageType[] = "gnubby-auth";
-
// SecurityKey extension message data members.
const char kConnectionId[] = "connectionId";
const char kControlMessage[] = "control";
@@ -87,7 +85,7 @@ bool SecurityKeyExtensionSession::OnExtensionMessage(
const protocol::ExtensionMessage& message) {
DCHECK(thread_checker_.CalledOnValidThread());
- if (message.type() != kExtensionMessageType) {
+ if (message.type() != kSecurityKeyExtensionMessageType) {
return false;
}
@@ -195,7 +193,7 @@ void SecurityKeyExtensionSession::SendMessageToClient(
CHECK(base::JSONWriter::Write(request, &request_json));
protocol::ExtensionMessage message;
- message.set_type(kExtensionMessageType);
+ message.set_type(kSecurityKeyExtensionMessageType);
message.set_data(request_json);
client_stub_->DeliverHostMessage(message);
« no previous file with comments | « remoting/base/constants.cc ('k') | remoting/protocol/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698