Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 285623002: Rename GCMClient::Load to GCMClient::Start (Closed)

Created:
6 years, 7 months ago by jianli
Modified:
6 years, 7 months ago
Reviewers:
Nicolas Zea, fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Rename GCMClient::Load to GCMClient::Start This is to address TODO and keep the naming consistent. BUG=none TEST=none due to no functionality changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270020

Patch Set 1 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -74 lines) Patch
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/fake_gcm_client_factory.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_client_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service.cc View 7 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service_unittest.cc View 19 chunks +26 lines, -26 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
6 years, 7 months ago (2014-05-12 22:23:03 UTC) #1
fgorski
lgtm
6 years, 7 months ago (2014-05-12 22:44:55 UTC) #2
Nicolas Zea
lgtm
6 years, 7 months ago (2014-05-12 22:46:41 UTC) #3
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 7 months ago (2014-05-12 22:48:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/285623002/20001
6 years, 7 months ago (2014-05-12 22:51:12 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:02:19 UTC) #6
Message was sent while issue was closed.
Change committed as 270020

Powered by Google App Engine
This is Rietveld 408576698