chrome/browser/resources/settings/settings_page/settings_animated_pages.js - Issue 2856223007: MD Settings: Shorten page fade transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 2856223007: MD Settings: Shorten page fade transitions (Closed)

Patch Set: closure Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_animated_pages.html ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

index b90aefefae59a80fcaa6960ba5dd79815364b239..9fa356dce6083e9e59b26d249abcfbe8d4a466fc 100644

--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

@@ -121,8 +121,8 @@ Polymer({

if (newRoute.section == this.section && newRoute.isSubpage()) {

this.switchToSubpage_(newRoute, oldRoute);

} else {

- this.$.animatedPages.exitAnimation = 'fade-out-animation';

- this.$.animatedPages.entryAnimation = 'fade-in-animation';

+ this.$.animatedPages.exitAnimation = 'settings-fade-out-animation';

+ this.$.animatedPages.entryAnimation = 'settings-fade-in-animation';

this.$.animatedPages.selected = 'default';

}

@@ -154,8 +154,8 @@ Polymer({

this.$.animatedPages.entryAnimation = 'slide-from-left-animation';

} else {

// The old route is not a subpage or is at the same level, so just fade.

- this.$.animatedPages.exitAnimation = 'fade-out-animation';

- this.$.animatedPages.entryAnimation = 'fade-in-animation';

+ this.$.animatedPages.exitAnimation = 'settings-fade-out-animation';

+ this.$.animatedPages.entryAnimation = 'settings-fade-in-animation';

if (!oldRoute.isSubpage()) {

// Set the height the expand animation should start at before